Skip to content

Update dogs3 dependency #24742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankmcsherry merged 1 commit into from
Feb 2, 2024
Merged

Update dogs3 dependency #24742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion misc/cargo-vet/audits.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ version = "1.2.6"
[[audits.differential-dataflow]]
who = "Moritz Hoffmann <mh@materialize.com>"
criteria = "safe-to-deploy"
version = "0.12.0@git:c5b9baca0283f4d96f7e6f914de8578fb5c521de"
version = "0.12.0@git:9da4dd365cc2cb0bcd317198731c3c7d42f3f657"

[[audits.dynfmt]]
who = "Sean Loiselle <sean@materialize.io>"
Expand Down
8 changes: 6 additions & 2 deletions src/compute/src/render/join/delta_join.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,9 @@ where
let (oks, errs2) = dogsdogsdogs::operators::half_join::half_join_internal_unsafe(
&updates,
trace,
|time| time.step_back(),
|time, antichain| {
antichain.insert(time.step_back());

@petrosagg petrosagg Jan 30, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't yet give us "precise" compaction as described by the description of this PR yet, right? Do we plan to do this in MZ?

@frankmcsherry frankmcsherry Jan 31, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, it turns out. MZ's use is limited to Product<u64, PointStamp<u64>>, or whatever, and that happens to be a distributive lattice for which compaction by the meet of the frontier equals compaction by the frontier.

@frankmcsherry frankmcsherry Jan 31, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could update the logic to push in each coordinate stepped back independently, for idiomatic reasons, but math says that we don't need to do this.

@petrosagg petrosagg Feb 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting, thanks for the explanation!

},
comparison,
// TODO(mcsherry): investigate/establish trade-offs here; time based had problems,
// in that we seem to yield too much and do too little work when we do.
Expand Down Expand Up @@ -508,7 +510,9 @@ where
let oks = dogsdogsdogs::operators::half_join::half_join_internal_unsafe(
&updates,
trace,
|time| time.step_back(),
|time, antichain| {
antichain.insert(time.step_back());
},
comparison,
// TODO(mcsherry): investigate/establish trade-offs here; time based had problems,
// in that we seem to yield too much and do too little work when we do.
Expand Down