feat: add EIP-7702 signature validations - #5470
Merged
Merged
Conversation
matthewwalsh0
marked this pull request as ready for review
March 13, 2025 11:50
OGPoyraz
approved these changes
Mar 13, 2025
cryptotavares
approved these changes
Mar 13, 2025
| validateTypedSignatureRequestV1(messageData); | ||
| } else { | ||
| validateTypedSignatureRequestV3V4(messageData, currentChainId); | ||
| validateTypedSignatureRequestV3V4({ |
Contributor
There was a problem hiding this comment.
Can a malicious actor bypass the validations added, by calling eth_signTypedData?
Member
Author
There was a problem hiding this comment.
I assumed not as the resulting signature would be different as the format is different? I can try and test though.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add additional validations to
signTypedDatarequests to protect EOAs that have been upgraded to a smart contract account via EIP-7702.Specifically:
verifyingContractmatches any internal EOA account.primaryTypeisDelegationanddelegatormatches any internal EOA account.@metamask/accounts-controller.References
Changelog
See
CHANGELOG.md.Checklist