[FEATURE FLAG] feat: migrate assets domain to use the AssetsController - #77
Closed
ulissesferreira wants to merge 8 commits into
Closed
[FEATURE FLAG] feat: migrate assets domain to use the AssetsController#77ulissesferreira wants to merge 8 commits into
ulissesferreira wants to merge 8 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
ulissesferreira
temporarily deployed
to
default-branch
July 31, 2026 00:18 — with
GitHub Actions
Inactive
ulissesferreira
marked this pull request as draft
July 31, 2026 10:32
…pters Move legacy assets logic into SnapAssetsAdapter, add CoreAssetsAdapter for AssetsController reads, and keep AssetsService as a thin facade with inline stage routing. Resolve migration stage from remote flags in the Snap with a hardcoded fallback constant instead of a separate mode module or env vars.
This was referenced Jul 31, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssetsControlleractions from MetaMask Core.SNAP_OWNED_ASSETS,mapControllerAsset, and an assets migration mode resolver to route fungible asset reads throughAssetsControllerwhen the feature flag is enabled, with legacyAssetsServicebehavior as fallback.AssetsService, client wiring, and tests to support the feature-flagged migration path.Test plan
yarn workspace @metamask/tron-wallet-snap buildyarn workspace @metamask/tron-wallet-snap run testAssetsControllerwhen the migration flag is onMade with Cursor