refactor(tron-wallet-snap): extract SnapAssetsAdapter from existing AssetsService logic - #91
Draft
ulissesferreira wants to merge 7 commits into
Draft
refactor(tron-wallet-snap): extract SnapAssetsAdapter from existing AssetsService logic#91ulissesferreira wants to merge 7 commits into
ulissesferreira wants to merge 7 commits into
Conversation
2 tasks
…rvice Move existing assets logic into SnapAssetsAdapter and keep AssetsService as a thin facade that always delegates to the Snap adapter. Behavior unchanged; prepares for a later Core adapter / feature-flag routing PR.
Adapter lives one directory deeper than AssetsService; bump client, constants, and types imports to ../../../ and ../types respectively.
Update the manifest shasum, cover AssetsService facade delegation in tests, and use SnapAssetsAdapter.isFiat inside the adapter implementation.
ulissesferreira
force-pushed
the
WPN-1497-snap-adapter
branch
from
July 31, 2026 21:54
53be776 to
b517134
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ulissesferreira
changed the title
Move import suppressions to SnapAssetsAdapter and align test assertions with jest prefer-strict-equal rules.
The previous shasum was generated on macOS and did not match the bundle produced by CI on Linux, causing dirty-working-tree failures in build and test.
ulissesferreira
marked this pull request as draft
August 2, 2026 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adapters/SnapAssetsAdapter.tsAssetsServicewith a thin facade that delegates all public methods to the snap adapterJira
Test plan
yarn workspace @metamask/tron-wallet-snap buildyarn workspace @metamask/tron-wallet-snap run testStacks on #90 (Step 2/3).