DEVOPS-515: requires geoh5py 0.10 + pymatsolver constraint in conda recipe#60
Merged
Conversation
sebhmg
commented
Oct 21, 2024
| "empymod>=2.0.0", | ||
| "geoana>=0.5.0", | ||
| "geoh5py>=0.9.1,<0.11", | ||
| "geoh5py>=0.10.0-alpha.1, <0.11", |
Author
There was a problem hiding this comment.
stating that simpeg requires at geoh5py 0.10
I am not sure here: does this branch of simpeg work with geoh5 0.9, @domfournier ?
In any case, I suppose it is safer to be restrictive.
For now, geoh5py 0.10-alpha is not published to the public. Since simpeg is supposed to be installed in a Conda environment, that should be OK, as long as the environment has a geoh5py 0.10-alpha version (installed from the giithub repo, or from a published pre-release on our private conda or pip repo).
Does that sound right?
@domfournier , @SophieCurinier ?
There was a problem hiding this comment.
It might still work for 0.9.0, but probably safer to restrict as 0.10 breaks backward compatibility on the value_maps.
domfournier
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVOPS-515 - release branches to prepare distrib for Analyst 4.5