forked from simpeg/simpeg
-
Notifications
You must be signed in to change notification settings - Fork 2
DEVOPS-515: requires geoh5py 0.10 + pymatsolver constraint in conda recipe #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d1df6f3
[DEVOPS-515] pymatsolver version constraints in conda recipe too
sebhmg 1ad8562
[DEVOPS-515] add pre-commit hooks for commit message
sebhmg 3b84b32
[DEVOPS-515] apply pre-commit autoupdate
sebhmg 8182196
[DEVOPS-515] fix black in precommit and run it
sebhmg fd7691b
[DEVOPS-515] needs geoh5py >= 0.10.0-alpha
sebhmg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,22 @@ | ||
| default_language_version: | ||
| python: python3 | ||
| repos: | ||
| - repo: https://github.com/psf/black | ||
| - repo: https://github.com/psf/black-pre-commit-mirror | ||
| rev: 24.3.0 | ||
| hooks: | ||
| - id: black | ||
| language_version: python3 | ||
| - repo: https://github.com/pycqa/flake8 | ||
| rev: 7.0.0 | ||
| rev: 7.1.1 | ||
| hooks: | ||
| - id: flake8 | ||
| language_version: python3 | ||
| additional_dependencies: | ||
| - flake8-bugbear==23.12.2 | ||
| - flake8-builtins==2.2.0 | ||
| - flake8-mutable==1.2.0 | ||
| - flake8-rst-docstrings==0.3.0 | ||
| - flake8-docstrings==1.7.0 | ||
| - repo: https://github.com/MiraGeoscience/pre-commit-hooks | ||
| rev: v1.0.1 | ||
| hooks: | ||
| - id: prepare-commit-msg | ||
| - id: check-commit-msg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,7 +64,7 @@ def __init__( | |
| rho=rho, | ||
| sigmaMap=None, | ||
| rhoMap=None, | ||
| **kwargs | ||
| **kwargs, | ||
| ) | ||
| self.q = q | ||
| self.qMap = qMap | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stating that simpeg requires at geoh5py 0.10
I am not sure here: does this branch of simpeg work with geoh5 0.9, @domfournier ?
In any case, I suppose it is safer to be restrictive.
For now, geoh5py 0.10-alpha is not published to the public. Since simpeg is supposed to be installed in a Conda environment, that should be OK, as long as the environment has a geoh5py 0.10-alpha version (installed from the giithub repo, or from a published pre-release on our private conda or pip repo).
Does that sound right?
@domfournier , @SophieCurinier ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might still work for 0.9.0, but probably safer to restrict as 0.10 breaks backward compatibility on the value_maps.