chore: tighten parity-test header and error-handler comments#12
Merged
Conversation
Trims the parity-harness goal/methodology preamble in test/sql/parity/001_set.test down to a single short header pointing at the upstream regression file and noting the display-format divergence. Same pass over the remaining gap-note blocks (geomset / spans / splitN / set_hash / empty-array): keeps the technical content (which symbol is missing, where in the source) and drops the surrounding explanatory padding. Also tightens the MobilityduckMeosErrorHandler comment block in src/mobilityduck_extension.cpp the same way: keeps the load-bearing note about elog level numbering and that >= 21 throws, drops the narrative around it. No code or test logic changes; comments and one test-file header only.
nhungoc1508
force-pushed
the
chore/scrub-process-narrative
branch
from
c53406d to
49b4f09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comment-only cleanup in two files. No logic, no test behavior change.
test/sql/parity/001_set.test— the file's preamble explained the parity-harness methodology at length. Replaced with a short header pointing at the upstream regression file and noting the date/timestamp display-format divergence. Same pass over the remaining gap-note blocks (geomset, spans, splitN, set_hash, empty-array): keep the technical content (which symbol is missing, where in the source), drop the surrounding explanatory padding.src/mobilityduck_extension.cpp—MobilityduckMeosErrorHandlerhad a multi-paragraph comment narrating why the handler exists. Trimmed to the load-bearing facts: MEOS's default handler exits the process; we throw instead; level numbering follows PostgreSQL's elog with>= 21(ERROR/FATAL/PANIC) treated as fatal.Test plan