test(parity): 003_span.test — span regression mirror#13
Merged
Conversation
This was referenced Apr 25, 2026
Ports mobilitydb/test/temporal/queries/003_span.test.sql to test/sql/parity/003_span.test in DuckDB sqllogic format. Active queries cover I/O parse errors, asText, two-arg / four-arg span() constructors, span(date), span(timestamptz), span(date::timestamptz), canonicalize round-trips, accessors (lower/upper/lowerInc/upperInc/ duration/span_cmp), comparison operators, expand / shift / scale / shiftScale, floor / ceil / round (incl. -inf/inf), and DuckDB-native behavior on the rest of the source file. Skipped sections, each with a technical note: - range(<span>) / span(<range>) — PG daterange / tstzrange types are not part of DuckDB; the SQL surface for these conversions is not portable. - date::datespan / timestamptz::tstzspan casts not registered in src/temporal/span.cpp (Value_to_span exists as a scalar only). - span_hash / span_hash_extended not registered. MEOS symbols: span_hash, span_hash_extended. - Position operators (<<, >>, &<, &>, -|-, <<#, #>>, &<#, #&>) between spans and scalar values: src/temporal/span.cpp registers them with return type SpanType rather than BOOLEAN. They should be predicate scalars returning BOOLEAN.
estebanzimanyi
force-pushed
the
feat/parity-span
branch
from
618d849 to
adcf767
Compare
Member
Author
|
Refreshed against current main: removed mode skip blocks for now-landed bindings — |
estebanzimanyi
added a commit
that referenced
this pull request
Apr 28, 2026
Single-file inventory of MobilityDB's mobilitydb/test/geo/queries/ surface. Rather than one parity file per upstream regression file, this lists what each file covers, what's bound in MobilityDuck today, and what's missing. Bound surface (per direct audit of src/geo/tgeompoint.cpp): - tgeompoint / tgeometry I/O for instant / discrete / continuous / sequence-set - asText / asEWKT / memSize / interp / round / transform - Constructors (TGEOMPOINT, tgeompointInst, tgeompointSeq, tgeompointSeqSet) - Spatial accessors: getX/Y/Z, length, cumulativeLength, speed, direction, azimuth, angularDifference, trajectory - Topological predicates: e/a/t variants of Contains, Disjoint, Dwithin, Intersects, Touches - Set ops: makeSimple, isSimple, stops - Restrictions: atGeometry, atStbox, atValues, atTime and the matching minus* - Modification: appendInstant, appendSequence, insert, update, deleteTime, merge - Comparison: temporal_eq / temporal_ne / etc. - twCentroid, shortestLine, distance_gs, collect_gs Unbound surface (per upstream regression file, with cross-references to the temporal-side parity-batch PRs that cover the same gap): - 051_stbox: stbox tests (whole file currently skipped in test/sql/stbox.test for DuckDB 1.4 signature issues). - 052_tgeo / 052_tpoint: mostly bound — per-type ports would mirror PRs #13 / #17 / #18 patterns. - 053_*_inout: asMFJSON / asWKB / asHexWKB / asGeoJSON — verify which are bound. - 054_*_compops: same parser blocker as PR #24's 030 (?= / #=). - 056_*_spatialfuncs: bulk bound; setSRID-on-temporal and reference-system accessors missing. - 058_*_tile: same gap as PR #23's 025 but for tspatial. - 060_*_topops: same pattern as PR #25's 032_temporal_topops. - 062_*_posops: same pattern as PR #24's 034_temporal_posops plus spatial-direction operators. - 064_*_distance: <-> for tgeo / tpoint; partially bound (shortestLine, distance_gs). - 066_tpoint_similarity: specialisation of PR #23's 038. - 068_*_aggfuncs: same architectural blocker as PR #21 (no AggregateFunction infra). Suite: 747 assertions, 23 test cases.
nhungoc1508
pushed a commit
that referenced
this pull request
May 4, 2026
Single-file inventory of MobilityDB's mobilitydb/test/geo/queries/ surface. Rather than one parity file per upstream regression file, this lists what each file covers, what's bound in MobilityDuck today, and what's missing. Bound surface (per direct audit of src/geo/tgeompoint.cpp): - tgeompoint / tgeometry I/O for instant / discrete / continuous / sequence-set - asText / asEWKT / memSize / interp / round / transform - Constructors (TGEOMPOINT, tgeompointInst, tgeompointSeq, tgeompointSeqSet) - Spatial accessors: getX/Y/Z, length, cumulativeLength, speed, direction, azimuth, angularDifference, trajectory - Topological predicates: e/a/t variants of Contains, Disjoint, Dwithin, Intersects, Touches - Set ops: makeSimple, isSimple, stops - Restrictions: atGeometry, atStbox, atValues, atTime and the matching minus* - Modification: appendInstant, appendSequence, insert, update, deleteTime, merge - Comparison: temporal_eq / temporal_ne / etc. - twCentroid, shortestLine, distance_gs, collect_gs Unbound surface (per upstream regression file, with cross-references to the temporal-side parity-batch PRs that cover the same gap): - 051_stbox: stbox tests (whole file currently skipped in test/sql/stbox.test for DuckDB 1.4 signature issues). - 052_tgeo / 052_tpoint: mostly bound — per-type ports would mirror PRs #13 / #17 / #18 patterns. - 053_*_inout: asMFJSON / asWKB / asHexWKB / asGeoJSON — verify which are bound. - 054_*_compops: same parser blocker as PR #24's 030 (?= / #=). - 056_*_spatialfuncs: bulk bound; setSRID-on-temporal and reference-system accessors missing. - 058_*_tile: same gap as PR #23's 025 but for tspatial. - 060_*_topops: same pattern as PR #25's 032_temporal_topops. - 062_*_posops: same pattern as PR #24's 034_temporal_posops plus spatial-direction operators. - 064_*_distance: <-> for tgeo / tpoint; partially bound (shortestLine, distance_gs). - 066_tpoint_similarity: specialisation of PR #23's 038. - 068_*_aggfuncs: same architectural blocker as PR #21 (no AggregateFunction infra). Suite: 747 assertions, 23 test cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports
mobilitydb/test/temporal/queries/003_span.test.sqltotest/sql/parity/003_span.testin DuckDB sqllogic format. Same shape as PR #6's001_set.test: active queries reflect MobilityDuck's display format; queries that hit a missing binding, naming divergence, or DuckDB/PG syntax-portability boundary are wrapped inmode skipwith a short technical note.Active coverage:
asText(incl. negative-digits error),span()constructors and the two error cases (empty span, lower > upper),span(date),span(timestamptz),span(date::timestamptz),lower,upper,lowerInc,upperInc,duration,span_cmp,=,<>,<,<=,>,>=),expand(incl. NULL-on-collapse),shift,scale,shiftScalefor int/date/tstz,floor/ceil/roundfor floatspan (incl.-inf/infrounding).Skipped — each with a one-line technical note in the file:
range(<span>)/span(<range>)daterange/tstzrangetypes are not part of DuckDB; SQL surface not portabledate::datespan/timestamptz::tstzspancastssrc/temporal/span.cpp(onlyValue_to_spanscalar exists)span_hash/span_hash_extendedspan_hash,span_hash_extended<<,>>,&<,&>, `-,<<#,#>>,&<#,#&>`Test plan
make releasethenTZ=UTC ./build/release/test/unittest "<proj>/test/*"— full suite passes (758 assertions across 14 test cases).Drafted because it sits adjacent to the in-flight queue (#8/#9/#10/#11/#12) on main; mark ready when those land or merge it independently.