fix(web): prevent horizontal scrollbar in session search dialog - #1290
Merged
Conversation
The search sessions dialog used a column flex layout where the title and snippet had white-space: nowrap but no min-width: 0, so the flex items refused to shrink below their text width and overflowed, surfacing a horizontal scrollbar on the dialog body. Add min-width: 0 so they shrink and ellipsize instead.
🦋 Changeset detectedLatest commit: 1abbaa1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No related issue.
Problem
The session search dialog showed a horizontal scrollbar whenever a session title or a matched snippet was long. Each result row is a column flex container, and its title and snippet used
white-space: nowrapwithtext-overflow: ellipsisbut nomin-width: 0. Flex items default tomin-width: auto, so undernowrapthey refused to shrink below their full text width and overflowed the row, surfacing as a horizontal scrollbar on the dialog body instead of being truncated with an ellipsis.The workspace-name line in the same dialog did not have this problem because it already set
min-width: 0.What changed
Added
min-width: 0to the title and snippet so the flex items can shrink to the row width and the existing ellipsis styling takes effect, matching the workspace-name line.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.