Skip to content

Webpaste Rework Follow-up#2411

Merged
dumptruckman merged 1 commit into
masterfrom
webpaste_followup
Oct 5, 2020
Merged

Webpaste Rework Follow-up#2411
dumptruckman merged 1 commit into
masterfrom
webpaste_followup

Conversation

@nicegamer7

@nicegamer7 nicegamer7 commented Sep 19, 2020

Copy link
Copy Markdown
Member

This PR is just a follow-up to #2288. It makes a few changes to the code so that it's more in line with MV's coding style.

There's also two miscellaneous changes:

  • A new constructor was added to HttpAPIClient, making the code a bit cleaner.
  • An IllegalStateException was changed to an IllegalArgumentException because it's more correct.

@dumptruckman dumptruckman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dumptruckman dumptruckman merged commit 7585582 into master Oct 5, 2020
@dumptruckman dumptruckman deleted the webpaste_followup branch October 5, 2020 05:25
@dumptruckman dumptruckman added the hacktoberfest-accepted https://hacktoberfest.digitalocean.com/ label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted https://hacktoberfest.digitalocean.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants