Fix infinite end portal loop

[Yepoleb]

I don't know if this has any side effects, but it removed the "Cannot use null location!" exception and our server doesn't crash anymore.

Should resolve #113, #108, #105 and #104.

[fernferret]

Hrm I'll have a look this weekend, but pull requests that start off with "I
don't know if this has any side effects" don't give me a great vote of
confidence.

I looked at the patch (since it's super small) and have you tried making a
portal, and linking it to the same world? Ie: w:my_world (presuming portal
is in my_world). That's the use case that would seem to be broken by
cancelling the event.

On Sun, Aug 7, 2016 at 10:39 AM, Gabriel Huber notifications@github.com
wrote:

I don't know if this has any side effects, but it removed the "Cannot use
null location!" exception and our server doesn't crash anymore.

Should resolve #113
#113, #108
#108, #105
#105 and

#104 #104.

You can view, comment on, or merge this pull request online at:

#117
Commit Summary

• Fix infinite end portal loop

File Changes

• M src/main/java/com/onarandombox/MultiverseNetherPortals/
  listeners/MVNPPlayerListener.java
  https://github.com/Multiverse/Multiverse-NetherPortals/pull/117/files#diff-0
  (2)

Patch Links:

• https://github.com/Multiverse/Multiverse-NetherPortals/pull/117.patch
• https://github.com/Multiverse/Multiverse-NetherPortals/pull/117.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#117, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEca2uKGMVRPS3-eV96fpmofy_c-XfZks5qdgo6gaJpZM4JeiRr
.

[Yepoleb]

You're right, I don't have much confidence in the patch. I just wanted to point out the problem and a possible fix, so someone who knows the code could do it properly.

Are you aware that this is MV-NetherPortals, not MV-Portals? If anyone uses it to teleport to the same world, I think he's doing it wrong.

[zombachu]

I've been using this fix without any problems and it does resolve the linked issues. I would suggest accepting this pull request because this bug very easily leads to server crashes.

[Yepoleb]

I've created my own release as it's unlikely this PR will ever be merged. It can be found at https://github.com/yeahwhat-mc/Multiverse-NetherPortals/releases/tag/portal_fix

[dumptruckman]

I don't understand. What are the steps to reproduce the problem?

[Yepoleb]

Create an end portal in a world that has no end and jump into it.

[dumptruckman]

Huh what are the chances someone opened a ticket for that just today. #123 I'll take a look at this soon.

[Yepoleb]

He was the one who asked asked for a download on my commit, so the chances are actually pretty good :D.

[fernferret]

Heh, yea, sorry guys, I've (again) gotten too busy to look at PRs :/

…

On Wed, Mar 15, 2017 at 10:44 PM, Gabriel Huber ***@***.***> wrote: He was the one who asked asked for a download on my commit <CoolLord22/Multiverse-NetherPortals@cf3292f>, so the chances are actually pretty good :D. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#117 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEca-fVcexyuiZLL3iC2ndhTPN7gaO0ks5rmL47gaJpZM4JeiRr> .

[mibby]

@fernferret Any update to this issue?

[nicegamer7]

This is no longer needed as of #181.