Event Listener Bug Scrub#181
Merged
Merged
Conversation
This was
linked to
issues
Oct 2, 2020
21 tasks
nicegamer7
force-pushed
the
event_tweaks
branch
from
d486302 to
e7f1cad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a rewrite of the event record with a purpose built class. This fixes #157. I also added a config option to disable the message sent when there is no world to teleport the player to, this closes #145.
Additionally, some changes were made to the event listeners to fix #104, #110, and #158. The problem was that MV-NetherPortals was setting the destination of portal events to
null, causing an error.Also additionally, some changes were made to the event listeners to fix #144 and #164. The problem here was that MV-NetherPortals was using the block that triggered the event to detect which type of portal the player entered instead of using the info given by the event.
Finally, I made it so that when a world is linked to itself, portals are disabled. This fixes #165. I also added a config option to disable the message sent when entering a disabled portal.
Now, I want to apologize for this huge PR, I'll try working on breaking my PRs up in the future.
P.S. This PR is the same as #163, it's just complete (I won't be making any more changes, I promise)!