Clean up and fix cooldown checking and message code.#538
Closed
hintron wants to merge 1 commit into
Closed
Conversation
dumptruckman
requested changes
Aug 26, 2020
dumptruckman
left a comment
dumptruckman
left a comment
Member
There was a problem hiding this comment.
These are excellent changes. Thank you! My only nitpick is that we (and Java in general) use lowerCamelCase for variable names instead of snake_case. Any change you could update the names for us?
There were too many levels of indirection, leading to multiple sample times and wasteful date object instantiations. Fixes Multiverse#444
Contributor
Author
|
Ok, I made the changes you asked for. Hopefully I did it correctly - not very familiar with this workflow. |
Closed
Member
|
Not sure why GitHub closed this. I changed the branch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were too many levels of indirection, leading to multiple sample
times and wasteful date object instantiations. The message logic was also just wrong.
Fixes #444