Clean up and fix cooldown checking and message code.#600
Merged
Conversation
There were too many levels of indirection, leading to multiple sample times and wasteful date object instantiations. Fixes #444
benwoo1110
reviewed
Dec 12, 2020
benwoo1110
left a comment
benwoo1110
left a comment
Member
There was a problem hiding this comment.
Here are some of my suggestion 👍
benwoo1110
reviewed
Dec 14, 2020
nicegamer7
commented
Dec 14, 2020
benwoo1110
reviewed
Dec 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the change made in #538, with some additional cleanup.
#538 fixed a few issues such as sending the cooldown twice, and enacting cooldown on the first time a player enters a nether-style portal. This PR does not include any additional fixes.
P.S. I tested this right before opening this PR, it's all working as expected :)