Add fedimint#867
Conversation
1490040 to
40d7c03
Compare
6c8fd87 to
42a5801
Compare
678e341 to
d65918f
Compare
1213ec7 to
4ea9d43
Compare
47a10be to
5e0aa52
Compare
1842a44 to
1ea8a05
Compare
40ecd2f to
bbc5c8c
Compare
|
We can pull out the first 2 commits separately and just merge that for now if we want, not sure how close we are getting here |
benthecarman
left a comment
There was a problem hiding this comment.
Went through commit by commit this time. Mostly nits again, what is left before we can merge this?
f70c0bb to
b2b58ec
Compare
|
I got payment status working though labels don't for some reason. Going to clean up and get that working tomorrow. |
|
This is ready @benthecarman I say we handle LNURL pay/withdraw in a follow up along with you fixing a couple of the NWC tests in a follow up too. I don't think they'd require any foundational change, mostly a bit of manual work that's not worth blocking on. |
|
@benthecarman please review the last 3 commits.
|
benthecarman
left a comment
There was a problem hiding this comment.
one tiny nit, otherwise lgtm.
You can just take my commit and merge it into your last one if you want, would make the commits a little cleaner.
Done |
|
🚢 it 🚀 |
TODO:
Follow up: