Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

Add fedimint#867

Merged
AnthonyRonning merged 12 commits into
masterfrom
add-fedimint
Dec 21, 2023
Merged

Add fedimint#867
AnthonyRonning merged 12 commits into
masterfrom
add-fedimint

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Nov 19, 2023

Copy link
Copy Markdown
Contributor

TODO:

  • payment storage in gluesql
  • Get labels to work properly with fedimint payments
  • NWC Invoice Payer

Follow up:

  • LNURL out of fedimint

@AnthonyRonning
AnthonyRonning force-pushed the add-fedimint branch 6 times, most recently from 1490040 to 40d7c03 Compare November 22, 2023 05:17
Comment thread mutiny-core/Cargo.toml Outdated
@AnthonyRonning
AnthonyRonning force-pushed the add-fedimint branch 2 times, most recently from 6c8fd87 to 42a5801 Compare November 23, 2023 21:22
Comment thread mutiny-core/src/fedimint.rs Outdated
Comment thread mutiny-core/src/fedimint.rs Outdated
Comment thread mutiny-core/src/nodemanager.rs Outdated
@AnthonyRonning
AnthonyRonning force-pushed the add-fedimint branch 2 times, most recently from 678e341 to d65918f Compare November 24, 2023 01:49
@AnthonyRonning
AnthonyRonning force-pushed the add-fedimint branch 3 times, most recently from 1213ec7 to 4ea9d43 Compare November 27, 2023 21:55
Comment thread mutiny-core/src/fedimint.rs Outdated
Comment thread mutiny-core/src/fedimint.rs Outdated
@AnthonyRonning
AnthonyRonning force-pushed the add-fedimint branch 4 times, most recently from 47a10be to 5e0aa52 Compare November 28, 2023 20:58
@benthecarman benthecarman mentioned this pull request Nov 28, 2023
2 tasks
@AnthonyRonning
AnthonyRonning force-pushed the add-fedimint branch 5 times, most recently from 1842a44 to 1ea8a05 Compare November 29, 2023 03:36
@AnthonyRonning
AnthonyRonning force-pushed the add-fedimint branch 2 times, most recently from 40ecd2f to bbc5c8c Compare December 18, 2023 05:02
@benthecarman

benthecarman commented Dec 18, 2023

Copy link
Copy Markdown
Collaborator

We can pull out the first 2 commits separately and just merge that for now if we want, not sure how close we are getting here

@benthecarman benthecarman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through commit by commit this time. Mostly nits again, what is left before we can merge this?

Comment thread mutiny-core/src/lib.rs Outdated
Comment thread mutiny-core/src/federation.rs Outdated
Comment thread mutiny-core/src/lib.rs Outdated
Comment thread mutiny-core/src/lib.rs
Comment thread mutiny-core/src/lib.rs Outdated
Comment thread mutiny-core/src/lib.rs Outdated
Comment thread mutiny-core/src/lib.rs Outdated
Comment thread mutiny-core/src/lib.rs Outdated
Comment thread mutiny-core/src/sql/glue.rs Outdated
Comment thread mutiny-core/src/sql/glue.rs Outdated
@AnthonyRonning
AnthonyRonning force-pushed the add-fedimint branch 3 times, most recently from f70c0bb to b2b58ec Compare December 18, 2023 21:47
@AnthonyRonning

Copy link
Copy Markdown
Contributor Author

I got payment status working though labels don't for some reason. Going to clean up and get that working tomorrow.

Comment thread mutiny-core/src/nostr/nwc.rs Outdated
@AnthonyRonning

Copy link
Copy Markdown
Contributor Author

This is ready @benthecarman

I say we handle LNURL pay/withdraw in a follow up along with you fixing a couple of the NWC tests in a follow up too. I don't think they'd require any foundational change, mostly a bit of manual work that's not worth blocking on.

@benthecarman benthecarman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 2 nits

Comment thread mutiny-core/src/lib.rs Outdated
Comment thread mutiny-core/src/lib.rs Outdated
Comment thread mutiny-core/src/lib.rs Outdated
@AnthonyRonning

Copy link
Copy Markdown
Contributor Author

@benthecarman please review the last 3 commits.
I've done the following:

  • Removed more references to node_manager and node inside of nwc
  • Added another method to the trait in order to handle invoice creation (for one time nwc)
  • I've renamed LnPayer to InvoiceHandler since it now generates, checks, and pays invoices

@benthecarman benthecarman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny nit, otherwise lgtm.

You can just take my commit and merge it into your last one if you want, would make the commits a little cleaner.

Comment thread mutiny-core/src/lib.rs Outdated
@AnthonyRonning

Copy link
Copy Markdown
Contributor Author

one tiny nit, otherwise lgtm.

You can just take my commit and merge it into your last one if you want, would make the commits a little cleaner.

Done

@benthecarman

Copy link
Copy Markdown
Collaborator

🚢 it 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants