Federations - #746
Conversation
Deploying with
|
| Latest commit: |
561d55f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8ce60064.mutiny-web.pages.dev |
| Branch Preview URL: | https://update-v0-5-0.mutiny-web.pages.dev |
3dbdaee to
bef6345
Compare
|
ready for more frontend testing, just without the persistent storage. Here's a federation invite code on signet: |
bef6345 to
f42eb3a
Compare
dd72b81 to
cb4c2a9
Compare
8e6a3a7 to
42f0064
Compare
42f0064 to
8915dd5
Compare
407b536 to
69e0ebf
Compare
futurepaul
left a comment
futurepaul
left a comment
There was a problem hiding this comment.
lgtm / works on my machine. tested on chrome and in safari on ios and as ios app on device
| (state.balance?.lightning || 0n) + | ||
| (state.balance?.federation || 0n); |
There was a problem hiding this comment.
we are doing this a bunch everywhere, probably a good indication we should add in mutiny-core something like can_pay_lightning(amt) that checks both federation and lightning balance. Good for a follow up though
| description: | ||
| "Mutiny has experimental support for the Fedimint protocol. You'll need a federation invite code to use this feature. These funds are currently not backed up remotely. Store funds in a federation at your own risk!", |
There was a problem hiding this comment.
Could note something about rug-pull risk here too, fine for now though
| key={i18n.t("settings.manage_federations.expires")} | ||
| > | ||
| <time> | ||
| {timeAgo(props.fed.federation_expiry_timestamp)} |
There was a problem hiding this comment.
timeAgo isn't the best name for this function now since it is returning a future time, but fine for now i guess
There was a problem hiding this comment.
Would be good to display a warning or something if the expiration is in the past though
a131683 to
561d55f
Compare
3 participants
Depends on MutinyWallet/mutiny-node#867