[FEATURE] Represent Selector as Component objects#1496
Conversation
4a4d0f0 to
0effcdb
Compare
|
Would like initial feedback on this... There's a bit more to do:
It might be possible to break this down into seperate PR, but I can't think how - everything is interdependent. |
0effcdb to
9927247
Compare
Perhaps an initial change would be to have |
#1498 covers exceptions possibly being thrown by |
a415794 to
a7b1af1
Compare
a7b1af1 to
557149c
Compare
Have added the additional tests and changelog entry. |
557149c to
2aab41f
Compare
Now actually committed that update. |
This does not include the string value, because it will be changed in #1496.
|
#1499 partially implements |
1de46dc to
6f95107
Compare
|
I've tidied up a few things, and reduced the diff with a pre-PR. I can't see any other possible pre-PRs, so this is ready for re-review. |
oliverklee
left a comment
There was a problem hiding this comment.
Looks very good! Only one nit.
Use `non-empty-list` and `non-empty-string` where applicable.
|
I spotted a few type annotations in |
This now may throw an `UnexpectedTokenException` rather than an `UnexpectedValueException`.
|
Also now corrected a |
Part of #1325.