Skip to content

[BUGFIX] Allow selector combinators in pseudo-class functions#1537

Merged
oliverklee merged 1 commit into
mainfrom
bugfix/selector-combinators-in-functions
Feb 18, 2026
Merged

[BUGFIX] Allow selector combinators in pseudo-class functions#1537
oliverklee merged 1 commit into
mainfrom
bugfix/selector-combinators-in-functions

Conversation

@JakeQZ

@JakeQZ JakeQZ commented Feb 18, 2026

Copy link
Copy Markdown
Collaborator

The bug was introduced by #1496 and related changes that split selector representation and parsing into compound selectors and combinators.

The regex for CompoundSelector::isValid() now matches that for Selector::isValid().

Fixes #1533

@JakeQZ JakeQZ requested a review from oliverklee February 18, 2026 19:37
@JakeQZ JakeQZ self-assigned this Feb 18, 2026
@JakeQZ JakeQZ added the bug label Feb 18, 2026
The bug was introduced by #1496 and related changes that split selector
representation and parsing into compound selectors and combinators.

The regex for `CompoundSelector::isValid()` now matches that for
`Selector::isValid()`.

Fixes #1533
@JakeQZ JakeQZ force-pushed the bugfix/selector-combinators-in-functions branch from b80d4b6 to cab97bf Compare February 18, 2026 19:39
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 72.384%. remained the same
when pulling cab97bf on bugfix/selector-combinators-in-functions
into 17dd54a on main.

@oliverklee oliverklee merged commit a32cddc into main Feb 18, 2026
24 checks passed
@oliverklee oliverklee deleted the bugfix/selector-combinators-in-functions branch February 18, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Selector rendering has additional whitespace that breaks the CSS

3 participants