[TASK] Rename Rule::$rule to Rule::$propertyName#1506
Merged
Conversation
JakeQZ
added
cleanup
deprecation
This has become a misnomer. Rules are the outer enclosing blocks. Deprecate the existing setters and getters and add new ones. (The name of the `Rule` class itself is also a misnomer.) Ref: https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/CSS_Declaration
JakeQZ
force-pushed
the
task/rename-rule-rule
branch
from
9387189 to
ebbb247
Compare
oliverklee
reviewed
Feb 12, 2026
oliverklee
approved these changes
Feb 12, 2026
JakeQZ
added a commit
that referenced
this pull request
Feb 13, 2026
This method replaces `getRule()`, which is deprecated as of #1506.
JakeQZ
added a commit
that referenced
this pull request
Feb 13, 2026
This method replaces `getRule()`, which is deprecated as of #1506.
oliverklee
pushed a commit
that referenced
this pull request
Feb 14, 2026
This method replaces `getRule()`, which is deprecated as of #1506.
JakeQZ
added a commit
that referenced
this pull request
Feb 14, 2026
This method replaces `getRule()`, which is deprecated as of #1506.
oliverklee
pushed a commit
that referenced
this pull request
Feb 14, 2026
This method replaces `getRule()`, which is deprecated as of #1506.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has become a misnomer. Rules are the outer enclosing blocks.
Deprecate the existing setters and getters and add new ones.
(The name of the
Ruleclass itself is also a misnomer.)Ref: https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/CSS_Declaration