Skip to content

[TASK] Use Declaration::getPropertyName() in tests#1520

Merged
oliverklee merged 1 commit into
mainfrom
task/tests-getpropertyname
Feb 14, 2026
Merged

[TASK] Use Declaration::getPropertyName() in tests#1520
oliverklee merged 1 commit into
mainfrom
task/tests-getpropertyname

Conversation

@JakeQZ

@JakeQZ JakeQZ commented Feb 13, 2026

Copy link
Copy Markdown
Collaborator

This method replaces getRule(), which is deprecated as of #1506.

@JakeQZ JakeQZ requested a review from oliverklee February 13, 2026 23:47
@JakeQZ JakeQZ self-assigned this Feb 13, 2026
@JakeQZ JakeQZ added testing PRs/issues adding additional tests only, or primarily testing-focused developer-specific Issues that only affect maintainers, contributors, and people submitting PRs refactor For PRs that refactor code without changing functionality labels Feb 13, 2026
@coveralls

coveralls commented Feb 13, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 72.791%. remained the same
when pulling 231195a on task/tests-getpropertyname
into 0a37763 on main.

@oliverklee oliverklee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The branch has conflicts and needs a rebase, though.

This method replaces `getRule()`, which is deprecated as of #1506.
@JakeQZ JakeQZ force-pushed the task/tests-getpropertyname branch from abba8c0 to 231195a Compare February 14, 2026 14:00
@oliverklee oliverklee merged commit f6ddd48 into main Feb 14, 2026
24 checks passed
@oliverklee oliverklee deleted the task/tests-getpropertyname branch February 14, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer-specific Issues that only affect maintainers, contributors, and people submitting PRs refactor For PRs that refactor code without changing functionality testing PRs/issues adding additional tests only, or primarily testing-focused

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants