[BUGFIX] Make class aliases available for consumers

[oliverklee]

Fixes #1532

[coveralls]

coverage: 72.181% (+0.07%) from 72.114%
when pulling 7640d31 on bugfix/class-aliases-in-phpstan
into 447fcb8 on main.

[JakeQZ]

Could we not keep the class alias files in their original locations, and just have the two files explicitly loaded via Composer?

That way

• we don't need to introduce a new root-level directory along with config file changes that we'll have to undo when we drop the aliases for the next major release;
• the separate alias files remain in a source directory representing the namespace of the alias (i.e. the old name of the class), and the deprecation notices make more sense.

[JakeQZ]

These should be in alphabetical order.

[oliverklee]

Could we not keep the class alias files in their original locations, and just have the two files explicitly loaded via Composer?

I'll give it a try …

[oliverklee]

Okay, done and repushed.

[JakeQZ]

Much cleaner :)

I assume it still works.

[oliverklee]

I assume it still works.

It does indeed (at least on my machine).

[JakeQZ]

Relevant PHPStan issues that were not resolved which means we need the Composer workaround:

• Add support for class_alias phpstan/phpstan#7296
• class_alias not taken into account phpstan/phpstan#8414

[JakeQZ]

I assume it still works.

It does indeed (at least on my machine).

I'm now getting errors from Stan saying it can't find the classes, within the PHP-CSS-Parser project alone. But maybe Composer hasn't updated the class loaders. When I run composer update it says there's nothing to update.

[oliverklee]

I'm now getting errors from Stan saying it can't find the classes,

I got those as well. It turned out I needed to delete the PHPStan caches (which on my Linux machine are located in /tmp/phstan/).

[JakeQZ]

I'm now getting errors from Stan saying it can't find the classes,

I got those as well. It turned out I needed to delete the PHPStan caches (which on my Linux machine are located in /tmp/phstan/).

"./vendor/bin/phpstan" clear-result-cache

does the job and should work on both Windows and Linux. I think we have some other cache-clearing commands in composer.json that this could be added to...

[JakeQZ]

I think we have some other cache-clearing commands in composer.json that this could be added to...

We don't seem to have any cache-clearing commands any more. Perhaps they were for tools that we stopped using.