[BUGFIX] Avoid double autoloading of class aliases

[oliverklee]

Fixes #1546
Fixes #1557

[JakeQZ]

If this doesn't work, an alternative would be to wrap the class_alias() calls in a class_exists() check, e.g.

if (!\class_exists(Rule::class, false)) {
    /**
     * @deprecated in v9.2, will be removed in v10.0.  Use `Property\Declaration` instead, which is a direct replacement.
     */
    class_alias(Declaration::class, Rule::class);
}

I think that should work, and I'd actually prefer it:

• It avoids introducing an additional root-level directory along with the associated configuration/command changes;
• We can keep the aliasing files in the location of the old classes -
  • If PHPStan is updated to support recognizing class aliases without the files being specifically preloaded, we can then simply remove the autoload.files section from composer.json (the only reason the files are being preloaded is to avoid PHPStan warnings in consumer projects - [BUGFIX] Make class aliases available for consumers #1534).

[oliverklee]

I've added the wrappers now.

[coveralls]

coverage: 72.886% (-0.1%) from 73.02%
when pulling 3964955 on bugfix/class-aliases
into dfdf183 on main.

[JakeQZ]

I've added the wrappers now.

With the wrappers added, would it be possible to keep the class_alias files in their original location, so that we don't have to introduce an additional root-level directory and change the commands in composer.json?

[JakeQZ]

Moving the files to a class-aliases directory does not help, as reported in #1546 (comment):

Moving the references from 'src' to 'class-aliases' is just changing where the problem happens.

I think we should keep the files in their original location, to avoid introducing a new root-level directory and potential confusion. I'm hopeful that the class_exists() test will solve the problem.

[JakeQZ]

I think we should pass false as the second argument to class_exists() and interface_exists() to avoid any unwanted autoloading.

[JakeQZ]

I think we should pass false as the second argument to class_exists() and interface_exists() to avoid any unwanted autoloading.

[JakeQZ]

We should probably make a 9.2.1 release with this fix, since there have been several reports of the issue since 9.2.0 which was only released a few days ago.

[oliverklee]

As we've added a new feature, this would then be a 9.3.0 release.