[TASK] Deprecate DeclarationBlock::expandShorthands#558
Merged
oliverklee merged 5 commits intoJun 18, 2024
Conversation
The `expandShorthands`/`createShorthands` Functions are deprecated and will be removed without substitution in version 10.0. Expanding and creating the shorthand notation is out of the scope of this library. If you want to include this functionality in your project or build it into a separate package, get the code from the v8.5.1 version of this library. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
deprecate-shorthand-functions_1
branch
from
00a8754 to
814d923
Compare
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Contributor
Author
|
I removed the now superfluous tests. |
sabberworm
reviewed
Jun 18, 2024
oliverklee
requested changes
Jun 18, 2024
oliverklee
left a comment
oliverklee
left a comment
Collaborator
There was a problem hiding this comment.
Let's deprecate it (with a corresponding changelog entry), but keep the functionality intact.
In the commit message and PR title, this should be a [TASK], not a mere (code) [CLEANUP].
oliverklee
changed the title
DeclarationBlock::expandShorthandsDeclarationBlock::expandShorthands
oliverklee
requested changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
expandShorthands/createShorthandsFunctions are deprecated and will be removed without substitution in version 10.0. Expanding and creating the shorthand notation is out of the scope of this library. If you want to include this functionality in your project or build it into a separate package, get the code from the v8.5.1 version of this library.Helps with fixing #512