[TASK] Deprecate DeclarationBlock::expandShorthands#568
Closed
ziegenberg wants to merge 0 commit into
Closed
Conversation
ziegenberg
force-pushed
the
deprecate-shorthand-functions_4
branch
from
cbec030 to
83659bb
Compare
Contributor
Author
|
Rebased it. |
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
approved these changes
Jun 19, 2024
Collaborator
|
Is the |
oliverklee
requested changes
Jun 19, 2024
oliverklee
left a comment
oliverklee
left a comment
Collaborator
There was a problem hiding this comment.
Indeed, this PR now looks strange.
Contributor
Author
|
I guess, something went missing while rebasing. I will have a look. |
ziegenberg
force-pushed
the
deprecate-shorthand-functions_4
branch
from
83659bb to
3a7a98a
Compare
ziegenberg
force-pushed
the
deprecate-shorthand-functions_4
branch
from
3a7a98a to
bf985db
Compare
Contributor
Author
|
Looks like this was a duplicate of #558. After rebasing, resolving the merge conflicts and pushing the PR closed on itself. |
Collaborator
|
It's magic! 😉 🪄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
expandShorthands/createShorthandsFunctions are deprecated and will be removed without substitution in version 10.0. Expanding and creating the shorthand notation is out of the scope of this library. If you want to include this functionality in your project or build it into a separate package, get the code from the v8.5.1 version of this library.Helps with fixing #512