Skip to content

update code quality services (for Python)#262

Merged
bouweandela merged 2 commits into
masterfrom
python_quality_services
Apr 22, 2022
Merged

update code quality services (for Python)#262
bouweandela merged 2 commits into
masterfrom
python_quality_services

Conversation

@egpbos

@egpbos egpbos commented Apr 6, 2022

Copy link
Copy Markdown
Collaborator

This PR fixes links to the Turing Way sections about online code quality services, which were all broken due to some updates there.

For Python specifically:

  • landscape.io doesn't exist anymore (at least over https)
  • add Sonarcloud, which is the default choice in the python template

- landscape.io doesn't exist anymore (at least over https)
- fix links to turing way section about online code quality services
- add Sonarcloud, which is the default choice in the python template
@egpbos egpbos requested a review from sverhoeven April 6, 2022 14:04
@egpbos

egpbos commented Apr 7, 2022

Copy link
Copy Markdown
Collaborator Author

Note to reviewer: the link checker is failing because of dead links in master. We should make a separate PR to fix them. In this PR, landscape.io is removed, which at least removes two of the dead links.

@bouweandela bouweandela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread best_practices/language_guides/python.md Outdated
Comment thread best_practices/language_guides/python.md Outdated
@egpbos

egpbos commented Apr 20, 2022

Copy link
Copy Markdown
Collaborator Author

As discussed, I replaced the specific suggestions with a link to The Turing Way. I expanded a bit on our default Python template choice, including @sverhoeven's suggestion to use SonarLint locally.

@egpbos egpbos requested a review from bouweandela April 20, 2022 11:11

@bouweandela bouweandela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bouweandela bouweandela merged commit e83e292 into master Apr 22, 2022
@bouweandela bouweandela deleted the python_quality_services branch April 22, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants