Skip to content

update complete Python chapter#263

Merged
egpbos merged 2 commits into
masterfrom
python_various_changes
Apr 7, 2022
Merged

update complete Python chapter#263
egpbos merged 2 commits into
masterfrom
python_various_changes

Conversation

@egpbos

@egpbos egpbos commented Apr 6, 2022

Copy link
Copy Markdown
Collaborator

I have gone over the full Python chapter now and made some further updates (apart from those in #259, #260, #261 and #262):

  • updated documentation section to recommend sphinx only (removed pydoc)
  • removed jupyterlab "under development" caveat, it's mature now
  • added ReviewNB suggestion based on good experiences in a number of projects
  • add some minor textual changes

- minor textual changes
- updated documentation section to recommend sphinx only (removed pydoc)
- removed jupyterlab "under development" caveat, it's mature now
- added ReviewNB suggestion based on good experiences in a number of projects
@egpbos egpbos changed the title various changes in Python chapter update complete Python chapter Apr 6, 2022
@egpbos egpbos requested a review from c-martinez April 6, 2022 14:04
@egpbos

egpbos commented Apr 7, 2022

Copy link
Copy Markdown
Collaborator Author

Note to reviewer: the link checker is failing because of dead links in master. We should make a separate PR to fix them.

@bouweandela bouweandela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Just a few more ideas, feel free to ignore them.

Comment thread best_practices/language_guides/python.md
Comment thread best_practices/language_guides/python.md
Comment thread best_practices/language_guides/python.md
Comment thread best_practices/language_guides/python.md Outdated
@egpbos egpbos merged commit d56210d into master Apr 7, 2022
@egpbos egpbos deleted the python_various_changes branch April 7, 2022 18:58
@egpbos

egpbos commented Apr 7, 2022

Copy link
Copy Markdown
Collaborator Author

Thanks for the review! Added your suggestions.

@c-martinez

Copy link
Copy Markdown
Member

Thanks for updates in this chapter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants