Linting issues template #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverhoeven
reviewed
Apr 30, 2021
sverhoeven
reviewed
Apr 30, 2021
|
|
||
| __author__ = "{{ cookiecutter.full_name }}" | ||
| __email__ = "{{ cookiecutter.email }}" | ||
| __version__ = __version__ |
sverhoeven
reviewed
Apr 30, 2021
sverhoeven
reviewed
Apr 30, 2021
sverhoeven
reviewed
Apr 30, 2021
|
|
||
| To make sure you have a proper linter configuration you need to follow the steps below. | ||
|
|
||
| 1. Update `description` and `keywords` fields in [setup.cfg]({{ cookiecutter.repository }}/blob/main/setup.cfg). |
Member
There was a problem hiding this comment.
How do I need to update it? Run prospector first
Co-authored-by: Stefan Verhoeven <stefan.verhoeven@gmail.com>
sverhoeven
requested changes
May 3, 2021
Member
sverhoeven
left a comment
sverhoeven
left a comment
There was a problem hiding this comment.
Instructions are clear and minimal.
This PR introduces several lint errors that should be fixed, see inline suggestions
{{cookiecutter.project_name}}/{{cookiecutter.package_name}}/my_module.py
Outdated
Show resolved
Hide resolved
…_module.py Co-authored-by: Stefan Verhoeven <stefan.verhoeven@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #238
Refs: #227 #228
This pull request adds an issue template which will be use to create an issue about linting fixes.