Skip to content

Update log#3

Closed
Thomas A Caswell (tacaswell) wants to merge 2 commits into
NSLS2:masterfrom
Olog:update-log
Closed

Update log#3
Thomas A Caswell (tacaswell) wants to merge 2 commits into
NSLS2:masterfrom
Olog:update-log

Conversation

@tacaswell

Copy link
Copy Markdown

No description provided.

@shroffk

Copy link
Copy Markdown

P.S. arkilic
I have also added another argument for defining timeout

@ghost

Copy link
Copy Markdown

Kunal Shroff (@shroffk) great, i wonder what other useful stuff you don't expose to the user that you've implemented on the server side

@shroffk

Copy link
Copy Markdown

This was my first python project so I am cleaning up and adding new feature as and when time permits.

@ghost

Copy link
Copy Markdown

👍

@danielballan

Copy link
Copy Markdown

Kunal Shroff (@shroffk) Would you be willing to do the rebase on this, since you are more familiar with the codebase than any of us?

@shroffk

Copy link
Copy Markdown

Ok, I will..

@danielballan

Copy link
Copy Markdown

Kunal Shroff (@shroffk) I keep getting requests for this functionality. Any chance you can make time to rebase this soon?

@danielballan

Copy link
Copy Markdown

cc brudhu

@shroffk

Copy link
Copy Markdown

The requested changes have been merged into the main pyolog library
Olog#7

regarding getting them into the NSLSII version, I looked at the pull request and the changes are quite numerous...Is there a way for me to get some input of what all the NSLSII changes incorporate.

@shroffk

Copy link
Copy Markdown

I do not have permission to accept this pull request, Dan Allan (@danielballan) would you be willing to resolve this with me.

@danielballan

Copy link
Copy Markdown

Yes, I'm not really familiar with either codebase (NSLS-II fork or upstream) but I'm wiling to help dig through this. Come find me today or tomorrow if you are around. (Office 150 now.)

@tacaswell

Copy link
Copy Markdown
Author

Replaced by #5 which just re-wrote the required functionality.

Dan Allan (danielballan) pushed a commit to danielballan/pyOlog that referenced this pull request Jan 5, 2017
MNT: more py3k compatibility fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants