Add the update support with the least possibly modification#5
Conversation
|
👍 Let me know what you need for the rewrite, I can give you a hand. We should have done this 3 years ago when we first discussed it |
|
Thanks, Kunal Shroff (@shroffk). Looks good to me. I'll let arkilic review and merge. |
| Simple test to create a ologClient | ||
| ''' | ||
| client = OlogClient(url='http://localhost:8080/Olog') | ||
| client = OlogClient(url=getDefaultTestConfig('url')) |
There was a problem hiding this comment.
I look at this library and compared to the java one it needs significant work, this is just one example of cleanup
There was a problem hiding this comment.
I have quite a few ideas. Let's discuss tmrw or sometime next week when you have time.
| import os.path | ||
| import ConfigParser | ||
| dflt={'url':'https://130.199.219.79:9992/Olog'} | ||
| dflt={'url':'https://localhost:8181/Olog'} |
ghost
merged commit 
|
Kunal Shroff (@shroffk) We currently use SimpleOlogClient. This change was made to OlogClient. Would adding this to SimpleOlogClient be as simple as copying the method updateLog over? |
|
Actually I think I figured it out for myself. I should have spend more time just reading the code. :- D |
|
I am glad you figured it ouw, I was just looking into it...i think the simpleOlogClinet might not be using the Log objects... |
2 participants
Adding the minimum update feature
I intend to do a (much needed) cleanup/rewrite of a significant portion of this library and will try to address the rest of the feature requests then.