feat: re-enable safe-synthesizer container runs - #599
Merged
Conversation
mckornfield
force-pushed
the
nss-container-runtime/mck
branch
from
July 7, 2026 21:02
73f3d2c to
85e1116
Compare
Contributor
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a ChangesSafe Synthesizer container image flow
Sequence Diagram(s)sequenceDiagram
participant JobsCompiler
participant Endpoints
participant SafeSynthesizerConfig
JobsCompiler->>Endpoints: compile job spec
Endpoints->>SafeSynthesizerConfig: read container_image_ref, container_image
alt container_image_ref set
Endpoints-->>JobsCompiler: use override image directly
else not set
Endpoints->>Endpoints: get_qualified_image(container_image)
Endpoints-->>JobsCompiler: use qualified image
end
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/safe-synthesizer/tutorials/safe-synthesizer-101.mdx`:
- Around line 39-42: The pip fallback command in the tutorial snippet has an
unterminated quote, which breaks the shell example. Update the install line in
the safe-synthesizer tutorial so it matches the quoting used by the uv pip
install example, with the kagglehub version and matplotlib each properly quoted
as needed. Check the shell snippet around the fallback install command to ensure
the quote is closed and the command is syntactically valid.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: bfd604fd-1d44-4d4e-a1e3-40b7a574a0e5
📒 Files selected for processing (10)
docker/Dockerfile.safe-synthesizer-tasksdocs/safe-synthesizer/tutorials/safe-synthesizer-101.mdxdocs/set-up/config-reference.mdxplugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/api/v2/jobs/endpoints.pyplugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/config.pyplugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/skills/safe-synthesizer/SKILL.mdplugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/skills/safe-synthesizer/workflows/config-runs.mdplugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/skills/safe-synthesizer/workflows/diagnose.mdplugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/skills/safe-synthesizer/workflows/run.mdplugins/nemo-safe-synthesizer/tests/unit/test_jobs.py
Contributor
|
mckornfield
force-pushed
the
nss-container-runtime/mck
branch
from
July 8, 2026 16:35
85e1116 to
266afd0
Compare
mckornfield
force-pushed
the
nss-container-runtime/mck
branch
from
July 8, 2026 21:21
e075efd to
f045054
Compare
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docker/Dockerfile.safe-synthesizer-tasks (1)
121-129: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winReplace
--constraintswith--constraintin all fouruv pip installcommands.uvonly accepts the singular flag, so this will fail the Docker build.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docker/Dockerfile.safe-synthesizer-tasks` around lines 121 - 129, The uv install commands are using the wrong plural constraints flag, which breaks the Docker build. Update every affected `uv pip install` invocation in `Dockerfile.safe-synthesizer-tasks` to use the singular `--constraint` option instead of `--constraints`, keeping the existing paths and other flags unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docker/Dockerfile.safe-synthesizer-tasks`:
- Around line 121-129: The uv install commands are using the wrong plural
constraints flag, which breaks the Docker build. Update every affected `uv pip
install` invocation in `Dockerfile.safe-synthesizer-tasks` to use the singular
`--constraint` option instead of `--constraints`, keeping the existing paths and
other flags unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 398a36f0-5cca-44ef-866d-22879753593f
📒 Files selected for processing (5)
.github/actions/setup-docker-buildx/action.yamldocker/Dockerfile.safe-synthesizer-taskspackages/nemo_platform_plugin/src/nemo_platform_plugin/jobs/file_manager.pypackages/nmp_common/tests/jobs/test_file_manager.pyplugins/nemo-safe-synthesizer/constraints.txt
✅ Files skipped from review due to trivial changes (1)
- plugins/nemo-safe-synthesizer/constraints.txt
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@plugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/skills/safe-synthesizer/workflows/config-runs.md`:
- Around line 135-142: The config-runs markdown uses fenced bash code blocks
that violate the repo’s markdownlint MD046 expectation. Update the affected
examples in this section to indented code blocks instead of fenced blocks,
keeping the same content while preserving the existing guidance around the Jobs
API/SDK and container execution settings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 493adec0-9047-45dd-98b1-da0e261f3efa
📒 Files selected for processing (16)
.github/actions/changes/action.yaml.github/actions/setup-docker-buildx/action.yaml.github/workflows/ci.yamldocker/Dockerfile.safe-synthesizer-tasksdocs/safe-synthesizer/tutorials/safe-synthesizer-101.mdxdocs/set-up/config-reference.mdxpackages/nemo_platform_plugin/src/nemo_platform_plugin/jobs/file_manager.pypackages/nmp_common/tests/jobs/test_file_manager.pyplugins/nemo-safe-synthesizer/constraints.txtplugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/api/v2/jobs/endpoints.pyplugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/config.pyplugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/skills/safe-synthesizer/SKILL.mdplugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/skills/safe-synthesizer/workflows/config-runs.mdplugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/skills/safe-synthesizer/workflows/diagnose.mdplugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/skills/safe-synthesizer/workflows/run.mdplugins/nemo-safe-synthesizer/tests/unit/test_jobs.py
✅ Files skipped from review due to trivial changes (4)
- plugins/nemo-safe-synthesizer/constraints.txt
- .github/actions/changes/action.yaml
- plugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/skills/safe-synthesizer/SKILL.md
- docs/set-up/config-reference.mdx
🚧 Files skipped from review as they are similar to previous changes (10)
- plugins/nemo-safe-synthesizer/tests/unit/test_jobs.py
- plugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/api/v2/jobs/endpoints.py
- docs/safe-synthesizer/tutorials/safe-synthesizer-101.mdx
- .github/actions/setup-docker-buildx/action.yaml
- packages/nemo_platform_plugin/src/nemo_platform_plugin/jobs/file_manager.py
- .github/workflows/ci.yaml
- docker/Dockerfile.safe-synthesizer-tasks
- plugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/skills/safe-synthesizer/workflows/run.md
- packages/nmp_common/tests/jobs/test_file_manager.py
- plugins/nemo-safe-synthesizer/src/nemo_safe_synthesizer_plugin/config.py
tylersbray
approved these changes
Jul 9, 2026
tylersbray
left a comment
tylersbray
left a comment
Contributor
There was a problem hiding this comment.
🤌 (channeling my inner Rob)
mckornfield
force-pushed
the
nss-container-runtime/mck
branch
2 times, most recently
from
July 9, 2026 20:41
037bc0f to
3b79508
Compare
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
mckornfield
force-pushed
the
nss-container-runtime/mck
branch
from
July 9, 2026 21:13
3b79508 to
ab2e340
Compare
mckornfield
enabled auto-merge
July 9, 2026 21:13
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation