Skip to content

chore: update fine tuning and nss images - #670

Merged
mckornfield merged 1 commit into
mainfrom
cve-container-images-0714/mck
Jul 14, 2026
Merged

chore: update fine tuning and nss images#670
mckornfield merged 1 commit into
mainfrom
cve-container-images-0714/mck

Conversation

@mckornfield

@mckornfield mckornfield commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Updates
    • Updated bundled ML and notebook dependencies to newer pinned versions, including Hugging Face Transformers and related components.
    • Refreshed Markdown/HTML and image-processing dependency constraints (e.g., mistune, soupsieve, pillow) to align with supported versions.
    • Updated the Safe Synthesizer runtime dependency on Weights & Biases to the newer pinned release.
    • Improved dependency consistency and cleanup during image builds to remove stale preinstalled artifacts so the intended versions are used.

@mckornfield
mckornfield requested review from a team as code owners July 14, 2026 14:52
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
@mckornfield
mckornfield force-pushed the cve-container-images-0714/mck branch from ac2ac4e to 971994d Compare July 14, 2026 14:53
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 65fd2ec9-ce36-4c59-bcbc-c885772d0e0c

📥 Commits

Reviewing files that changed from the base of the PR and between ac2ac4e and 971994d.

📒 Files selected for processing (4)
  • docker/Dockerfile.nmp-unsloth-training
  • docker/Dockerfile.safe-synthesizer-tasks
  • docker/automodel/Dockerfile.nmp-automodel-base
  • plugins/nemo-safe-synthesizer/constraints.txt
🚧 Files skipped from review as they are similar to previous changes (4)
  • docker/Dockerfile.safe-synthesizer-tasks
  • docker/Dockerfile.nmp-unsloth-training
  • plugins/nemo-safe-synthesizer/constraints.txt
  • docker/automodel/Dockerfile.nmp-automodel-base

📝 Walkthrough

Walkthrough

Updated container dependency pins, added mistune and soupsieve constraints and cleanup entries, upgraded wandb, and aligned Safe Synthesizer security constraints.

Changes

Dependency updates

Layer / File(s) Summary
Unsloth training dependency alignment
docker/Dockerfile.nmp-unsloth-training
Upgrades Transformers and Hugging Face Hub pins, adds mistune and soupsieve constraints, and removes stale base-image installations.
Automodel base dependency alignment
docker/automodel/Dockerfile.nmp-automodel-base
Raises JupyterLab, mistune, and Pillow minimum versions and expands stale-package cleanup.
Safe Synthesizer dependency alignment
docker/Dockerfile.safe-synthesizer-tasks, plugins/nemo-safe-synthesizer/constraints.txt
Upgrades wandb and updates mistune, Pillow, and soupsieve security constraints.

Possibly related PRs

Suggested labels: fix

Suggested reviewers: ironcommit, svvarom, tylersbray

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: Docker image dependency updates for fine-tuning and safe-synthesizer images.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cve-container-images-0714/mck

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
plugins/nemo-safe-synthesizer/constraints.txt (1)

20-26: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add upper bounds to keep cross-image resolutions aligned.

Match the sibling images with mistune<4, pillow<13, and soupsieve<3; lower bounds alone allow future major releases and unintentional dependency drift.

Proposed constraint update
-mistune>=3.3.3
+mistune>=3.3.3,<4
-pillow>=12.3.0
+pillow>=12.3.0,<13
-soupsieve>=2.8.4
+soupsieve>=2.8.4,<3
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@plugins/nemo-safe-synthesizer/constraints.txt` around lines 20 - 26, Update
the dependency constraints in constraints.txt to add the requested upper bounds:
use mistune>=3.3.3,<4, pillow>=12.3.0,<13, and soupsieve>=2.8.4,<3, while
preserving the existing lower bounds and all other constraints.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@plugins/nemo-safe-synthesizer/constraints.txt`:
- Around line 20-26: Update the dependency constraints in constraints.txt to add
the requested upper bounds: use mistune>=3.3.3,<4, pillow>=12.3.0,<13, and
soupsieve>=2.8.4,<3, while preserving the existing lower bounds and all other
constraints.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 99b31e6c-3998-4522-969e-9265e0e0bbc8

📥 Commits

Reviewing files that changed from the base of the PR and between 44ecead and ac2ac4e.

📒 Files selected for processing (4)
  • docker/Dockerfile.nmp-unsloth-training
  • docker/Dockerfile.safe-synthesizer-tasks
  • docker/automodel/Dockerfile.nmp-automodel-base
  • plugins/nemo-safe-synthesizer/constraints.txt

@github-actions github-actions Bot added the chore label Jul 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 23849/31015 76.9% 61.7%
Integration Tests 13815/29664 46.6% 19.6%

@ironcommit ironcommit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mckornfield
mckornfield added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit 712883a Jul 14, 2026
57 checks passed
@mckornfield
mckornfield deleted the cve-container-images-0714/mck branch July 14, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants