chore: update fine tuning and nss images - #670
Conversation
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
ac2ac4e to
971994d
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughUpdated container dependency pins, added ChangesDependency updates
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
plugins/nemo-safe-synthesizer/constraints.txt (1)
20-26: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd upper bounds to keep cross-image resolutions aligned.
Match the sibling images with
mistune<4,pillow<13, andsoupsieve<3; lower bounds alone allow future major releases and unintentional dependency drift.Proposed constraint update
-mistune>=3.3.3 +mistune>=3.3.3,<4 -pillow>=12.3.0 +pillow>=12.3.0,<13 -soupsieve>=2.8.4 +soupsieve>=2.8.4,<3🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/nemo-safe-synthesizer/constraints.txt` around lines 20 - 26, Update the dependency constraints in constraints.txt to add the requested upper bounds: use mistune>=3.3.3,<4, pillow>=12.3.0,<13, and soupsieve>=2.8.4,<3, while preserving the existing lower bounds and all other constraints.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@plugins/nemo-safe-synthesizer/constraints.txt`:
- Around line 20-26: Update the dependency constraints in constraints.txt to add
the requested upper bounds: use mistune>=3.3.3,<4, pillow>=12.3.0,<13, and
soupsieve>=2.8.4,<3, while preserving the existing lower bounds and all other
constraints.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 99b31e6c-3998-4522-969e-9265e0e0bbc8
📒 Files selected for processing (4)
docker/Dockerfile.nmp-unsloth-trainingdocker/Dockerfile.safe-synthesizer-tasksdocker/automodel/Dockerfile.nmp-automodel-baseplugins/nemo-safe-synthesizer/constraints.txt
|
Summary by CodeRabbit