Skip to content

fix: document and ci fix for py314 abi compatibility issue - #656

Merged
mckornfield merged 4 commits into
mainfrom
py314-abi-compat-issue/mck
Jul 13, 2026
Merged

fix: document and ci fix for py314 abi compatibility issue#656
mckornfield merged 4 commits into
mainfrom
py314-abi-compat-issue/mck

Conversation

@mckornfield

@mckornfield mckornfield commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation
    • Added Python 3.14-specific installation guidance across the README and setup/docs pages, including a temporary PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 pip install "nemo-platform[all]" workaround.
    • Updated the OSS support matrix with the same Python 3.14 note.
  • Bug Fixes
    • Improved CLI messaging for missing all extra dependencies by adding the Python 3.14 workaround.
  • Chores
    • Updated CI wheel smoke tests to apply the Python 3.14 compatibility setting during the install/test flow.

@mckornfield
mckornfield requested review from a team as code owners July 13, 2026 19:23
@github-actions github-actions Bot added the fix label Jul 13, 2026
@mckornfield

Copy link
Copy Markdown
Contributor Author

to answer @svvarom , there's no great way to set this for users, so I updated our docs pages about it

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2a5dd40f-2f23-46f8-875f-fc623675c1a7

📥 Commits

Reviewing files that changed from the base of the PR and between 826aa32 and e286d73.

⛔ Files ignored due to path filters (2)
  • sdk/python/nemo-platform/src/nemo_platform/cli/commands/services/cli.py is excluded by !sdk/**
  • sdk/python/nemo-platform/src/nemo_platform/cli/commands/setup.py is excluded by !sdk/**
📒 Files selected for processing (10)
  • .github/workflows/ci.yaml
  • README.md
  • docs/cli/index.mdx
  • docs/get-started/setup.mdx
  • docs/requirements.mdx
  • docs/support-matrix.mdx
  • packages/nemo_platform/README.md
  • packages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/services/cli.py
  • packages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/setup.py
  • packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md
🚧 Files skipped from review as they are similar to previous changes (10)
  • packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md
  • docs/get-started/setup.mdx
  • docs/requirements.mdx
  • packages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/services/cli.py
  • README.md
  • packages/nemo_platform/README.md
  • docs/cli/index.mdx
  • packages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/setup.py
  • docs/support-matrix.mdx
  • .github/workflows/ci.yaml

📝 Walkthrough

Walkthrough

Python 3.14 installation instructions, CLI dependency diagnostics, and wheel smoke tests now use the PyO3 ABI3 forward-compatibility setting required by the litellm Rust extension.

Changes

Python 3.14 compatibility

Layer / File(s) Summary
Python 3.14 installation guidance
README.md, docs/..., packages/*/README.md
Installation documentation adds the PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 workaround for nemo-platform[all].
CLI dependency error guidance
packages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/services/cli.py, packages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/setup.py
Missing dependency messages now include the Python 3.14 installation command alongside the standard command.
Python 3.14 wheel validation
.github/workflows/ci.yaml
The wheel smoke test sets the compatibility variable when running under Python 3.14.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: CI and documentation updates for Python 3.14 ABI compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch py314-abi-compat-issue/mck

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/cli/index.mdx`:
- Around line 45-52: Update the Python 3.14 installation guidance in the
documentation to include the equivalent PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 uv
pip install command alongside the existing pip command. Use a tab set for the
pip and uv variants, preserving the same package specifier and workaround in
both.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: df349943-973c-426f-9d86-7e98d79b3b02

📥 Commits

Reviewing files that changed from the base of the PR and between 275c8cd and 826aa32.

📒 Files selected for processing (10)
  • .github/workflows/ci.yaml
  • README.md
  • docs/cli/index.mdx
  • docs/get-started/setup.mdx
  • docs/requirements.mdx
  • docs/support-matrix.mdx
  • packages/nemo_platform/README.md
  • packages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/services/cli.py
  • packages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/setup.py
  • packages/nemo_platform_plugin/src/nemo_platform_plugin/README.md

Comment thread docs/cli/index.mdx
@mckornfield
mckornfield enabled auto-merge July 13, 2026 19:28
@github-actions

Copy link
Copy Markdown
Contributor

@mckornfield
mckornfield force-pushed the py314-abi-compat-issue/mck branch from 826aa32 to 6cf079b Compare July 13, 2026 19:38
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
@mckornfield
mckornfield force-pushed the py314-abi-compat-issue/mck branch from 6cf079b to ab9fb0c Compare July 13, 2026 19:39
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 23845/31009 76.9% 61.7%
Integration Tests 13816/29658 46.6% 19.6%

Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
@mckornfield
mckornfield added this pull request to the merge queue Jul 13, 2026
Merged via the queue into main with commit 625e51f Jul 13, 2026
57 of 59 checks passed
@mckornfield
mckornfield deleted the py314-abi-compat-issue/mck branch July 13, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants