fix: document and ci fix for py314 abi compatibility issue - #656
Conversation
|
to answer @svvarom , there's no great way to set this for users, so I updated our docs pages about it |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (10)
🚧 Files skipped from review as they are similar to previous changes (10)
📝 WalkthroughWalkthroughPython 3.14 installation instructions, CLI dependency diagnostics, and wheel smoke tests now use the PyO3 ABI3 forward-compatibility setting required by the ChangesPython 3.14 compatibility
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/cli/index.mdx`:
- Around line 45-52: Update the Python 3.14 installation guidance in the
documentation to include the equivalent PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 uv
pip install command alongside the existing pip command. Use a tab set for the
pip and uv variants, preserving the same package specifier and workaround in
both.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: df349943-973c-426f-9d86-7e98d79b3b02
📒 Files selected for processing (10)
.github/workflows/ci.yamlREADME.mddocs/cli/index.mdxdocs/get-started/setup.mdxdocs/requirements.mdxdocs/support-matrix.mdxpackages/nemo_platform/README.mdpackages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/services/cli.pypackages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/setup.pypackages/nemo_platform_plugin/src/nemo_platform_plugin/README.md
826aa32 to
6cf079b
Compare
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
6cf079b to
ab9fb0c
Compare
|
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Summary by CodeRabbit
PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 pip install "nemo-platform[all]"workaround.allextra dependencies by adding the Python 3.14 workaround.