Skip to content

Revert unverified EAGLE3 model examples; keep triage code + baseline #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yeyu-nvidia merged 1 commit into from
Jun 3, 2026
Merged

Revert unverified EAGLE3 model examples; keep triage code + baseline #1623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .claude/scheduled_tasks.lock
View file
Open in desktop

@sychen52 sychen52 Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file should not be committed in. @yeyu-nvidia

@yeyu-nvidia yeyu-nvidia Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — agreed, it's an ephemeral scheduler lock that slipped in. Removed from tracking + added a .gitignore rule in #1758.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"sessionId":"c73837a8-dfc8-4c65-87dd-ba6efe62db78","pid":5301,"procStart":"863627582","acquiredAt":1780509271557}
8 changes: 4 additions & 4 deletions examples/speculative_decoding/pipeline/eagle3/eagle3_new_model_triage_guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,10 @@ When adding a new patch:

## Step 6: Document results

Update `examples/speculative_decoding/pipeline/eagle3/eagle3_triage_chart.md`:
1. Update the model row in the **Model Test Matrix** (status + per-task results)
2. Add a **Per-Model Test Results** entry with experiment IDs, errors, and fixes
3. Add new failure patterns to the **Observed Failure Catalog**
Record the outcome of each run (status per task, experiment IDs, errors, and the fix
applied) in the team's internal triage tracker, and capture any new failure pattern so the
next model benefits. Once a model is verified end-to-end, add its launcher YAML example in a
dedicated PR.

## Known Model-Specific Issues

Expand Down
207 changes: 0 additions & 207 deletions examples/speculative_decoding/pipeline/eagle3/eagle3_triage_chart.md
View file
Open in desktop

This file was deleted.

111 changes: 0 additions & 111 deletions tools/launcher/examples/DeepSeek/DeepSeek-V3.2/eagle3_quick_check.yaml
View file
Open in desktop

This file was deleted.

Loading
Loading