[None][fix] Cherry pick 11621 - Accept **kwargs in DynamicYamlWithDeepMergeSettingsSource._read_files for pydantic-settings 2.13 compatibility - #11951
Conversation
Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>
Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com> Co-authored-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com>
…efill to decode in disagg (NVIDIA#11727) (NVIDIA#11792) Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com> Co-authored-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
…isagg) (NVIDIA#11832) Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com> Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com> Co-authored-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com> Co-authored-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
…ity scheduler (NVIDIA#11834) Signed-off-by: jthomson04 <jwillthomson19@gmail.com> Co-authored-by: jthomson04 <jwillthomson19@gmail.com>
…fill bug (NVIDIA#11805) (NVIDIA#11847) Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com> Co-authored-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
…1916) Signed-off-by: peihu-nv <259410613+peihu-nv@users.noreply.github.com> Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com> Co-authored-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
…._read_files for pydantic-settings 2.13 compatibility Signed-off-by: Tal Cherckez <127761168+tcherckez-nvidia@users.noreply.github.com>
|
/bot run |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (22)
📝 WalkthroughWalkthroughThis PR bumps the package version to 1.3.0rc5.post1 and introduces features for disaggregated inference: propagating first-generation logits and log probabilities from the prefill phase to the decode phase. Additionally, it refines KV cache reuse accounting by filtering allocated blocks, optimizes memory in DeepSeekV3, tightens None-safety checks in QwenVL models, adjusts fallback tactics for allreduce operations, and expands test coverage for disaggregated scenarios. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant ContextServer as Context Server<br/>(Prefill)
participant GenServer as Generation Server<br/>(Decode)
participant ParamTransfer as Parameter<br/>Transfer
Client->>ContextServer: Submit request with prompt
ContextServer->>ContextServer: Execute prefill phase<br/>Generate first tokens
ContextServer->>ContextServer: Compute first_gen_logits<br/>and first_gen_log_probs
ContextServer->>ParamTransfer: Package disaggregated_params<br/>with first_gen_* fields
ParamTransfer->>GenServer: Transfer params + first_gen_*<br/>to generation server
GenServer->>GenServer: Deserialize first_gen_logits<br/>and first_gen_log_probs
GenServer->>GenServer: Prepend first_gen_* to<br/>generation results
GenServer->>GenServer: Continue generation phase<br/>with prepended data
GenServer->>Client: Return combined response<br/>(prefill + generation)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
Summary by CodeRabbit
New Features
Bug Fixes
Performance
Chores
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.