[#12290][fix] Qwen 3.5 fix 3d position ID handling#12114
Conversation
|
Implementation update for the latest Qwen3.5 MoE AutoDeploy change set: Plan executed:
Validation summary:
Relevant local commands used for validation:
Latest branch commit: |
a08d87b to
48af4c3
Compare
f7ec732 to
1a27b0a
Compare
|
/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" --disable-fail-fast |
|
PR_Github #38845 [ run ] triggered by Bot. Commit: |
|
/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" --disable-fail-fast |
|
PR_Github #38846 [ run ] triggered by Bot. Commit: |
|
PR_Github #38846 [ run ] completed with state
|
de6312f to
aea2358
Compare
|
/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" --disable-fail-fast |
|
PR_Github #38888 [ run ] triggered by Bot. Commit: |
|
/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" --disable-fail-fast |
|
PR_Github #38888 [ run ] completed with state
|
|
/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" --disable-fail-fast |
|
PR_Github #38907 [ run ] triggered by Bot. Commit: |
|
PR_Github #38907 [ run ] completed with state
|
318cede to
c48de0b
Compare
|
/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" --disable-fail-fast |
|
PR_Github #38925 [ run ] triggered by Bot. Commit: |
|
PR_Github #38925 [ run ] completed with state |
|
/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" --disable-fail-fast |
|
PR_Github #38961 [ run ] triggered by Bot. Commit: |
|
PR_Github #38961 [ run ] completed with state
|
|
/bot run |
|
PR_Github #40039 [ run ] triggered by Bot. Commit: |
|
PR_Github #40039 [ run ] completed with state
|
|
/bot run --disable-fail-fast --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" |
|
PR_Github #40098 [ run ] triggered by Bot. Commit: |
|
PR_Github #40098 [ run ] completed with state
|
|
/bot run --disable-fail-fast --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" |
|
PR_Github #40145 [ run ] triggered by Bot. Commit: |
|
PR_Github #40145 [ run ] completed with state
|
|
/bot run --disable-fail-fast --reuse-test --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" |
|
PR_Github #40180 [ run ] triggered by Bot. Commit: |
|
PR_Github #40180 [ run ] completed with state
|
|
/bot run --reuse-test --stage-list "DGX_H100-4_GPUs-AutoDeploy-1" |
|
PR_Github #40332 [ run ] triggered by Bot. Commit: |
|
PR_Github #40331 [ run ] triggered by Bot. Commit: |
|
PR_Github #40332 [ run ] completed with state |
|
PR_Github #40331 [ run ] completed with state |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot skip --m "all tests passing" |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot skip --comment "all tests passing" |
|
PR_Github #40360 [ skip ] triggered by Bot. Commit: |
|
PR_Github #40360 [ skip ] completed with state |
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
Description
Fixes #12271
This updates the Qwen3.5 MoE AutoDeploy multimodal path to make mRoPE delta handling request-scoped and cache-backed, while keeping Qwen-specific multimodal span construction in the Qwen model path instead of the generic input processor.
Implemented changes:
input_idsin the Qwen-specific AutoDeploy pathmrope_delta_cachewhen availableinitialize_qwen_mrope_delta_cachetransform to allocate a tiny per-slot cache resourceposition_idsfallback so request-level deltas are expanded to per-token deltas usingcu_seqlenTest Coverage
Verified locally:
pytest -q tests/unittest/_torch/auto_deploy/unit/singlegpu/models/test_qwen3_5_moe.py -k "mrope_delta_matches_compute_mrope_positions_for_mixed_items or mrope_delta_with_cache_writes_prefill_and_reads_decode or flattened_prefill_with_request_deltas" -p no:cacheproviderTRTLLM_ACCURACY_NO_REFERENCE=1 TMPDIR=/tmp/trtqwen HF_HOME=/tmp/trtqwen/hf_home PYTHONDONTWRITEBYTECODE=1 pytest -q tests/integration/defs/accuracy/test_llm_api_autodeploy.py::TestQwen3_5_35B_MoE::test_bf16 -sResult from the full-model MMMU run:
mmmu_valaverage accuracy:40.111 passedPR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Summary by CodeRabbit
Release Notes
New Features
Tests