[None][fix] Register Multimodal Placeholders for Qwen3.5 MoE VLM Serving - #15079
Conversation
Signed-off-by: Anurag Saykar <anuragsaikar100@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds multimodal support for Qwen3.5 MoE by introducing a config subclass to preserve the model type identifier during normalization and registering multimodal placeholder metadata with conditional imports. ChangesQwen3.5 MoE multimodal support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bmarimuthu-nv
left a comment
There was a problem hiding this comment.
Thanks @anurags25 for the contribution!
|
/bot run |
|
PR_Github #52857 [ run ] triggered by Bot. Commit: |
|
PR_Github #52857 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #52962 [ run ] triggered by Bot. Commit: |
|
PR_Github #52962 [ run ] completed with state |
|
@anurags25 , just a note that I reverted your |
Summary
PR #12114 fixed model internals (mRoPE, chunked prefill, expert routing) but multimodal placeholders were not registers so the serving layer was unable to process multimodal requests. This change completes the fix for #12271.
MULTIMODAL_PLACEHOLDER_REGISTRYentry forqwen3_5_moein the AutoDeploy custom model, so the serving layer can resolve image/video placeholder tokens during chat message parsing_Qwen35MoeVLMConfigsubclass inconfig_utils.pyto preservemodel_type = "qwen3_5_moe"through the config normalization path (_Qwen35ConfigCompatconverts toQwen3NextConfig, which loses the original model_type)<|vision_start|><|image_pad|><|vision_end|>,<|vision_start|><|video_pad|><|vision_end|>) match the PyTorch backend'sqwen3_vl_moeregistrationTest plan
trtllm-serve <qwen3.5-35b-a3b> --backend=_autodeploy --config=<config.yaml>starts without errorSummary by CodeRabbit