[TRTLLM-12062][test] remove obsolete model tests - #13262
Conversation
|
/bot run --stage-list "" |
📝 WalkthroughWalkthroughMultiple test list manifests across QA and test-database configurations have been updated to remove test cases for various models including Phi-4, Mistral, Llama, and others. These changes rebalance test coverage selections across hardware configurations while adding limited new test cases to one manifest. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/qa/llm_function_core.txt (1)
861-906: Please confirm these newexamples/serve+ broadtest_e2eentries belong inllm_function_core.txt.
llm_function_core.txtis intended as the primary single-node multi-GPU functional list; these additions may broaden scope beyond core and increase daily/release runtime. If intentional, add a short rationale in PR notes; otherwise consider moving non-core cases tollm_function_full.txt(or a more appropriate QA list).
As per coding guidelines,llm_function_core.txtshould remain an intentional curated set for primary single-node multi-GPU functional scenarios.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/integration/test_lists/qa/llm_function_core.txt` around lines 861 - 906, The PR added many examples/serve tests and broad test_e2e entries into llm_function_core.txt which is meant to be a curated single-node multi-GPU functional list; either confirm they intentionally expand the core scope by adding a short rationale to the PR notes or remove/move the non-core entries (e.g., all examples/serve/test_serve.py and the wide set of test_e2e.py cases listed) from llm_function_core.txt into llm_function_full.txt (or another appropriate QA list), and update the PR description to state which tests remain in core vs moved so reviewers know the change intent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@tests/integration/test_lists/qa/llm_function_core.txt`:
- Around line 861-906: The PR added many examples/serve tests and broad test_e2e
entries into llm_function_core.txt which is meant to be a curated single-node
multi-GPU functional list; either confirm they intentionally expand the core
scope by adding a short rationale to the PR notes or remove/move the non-core
entries (e.g., all examples/serve/test_serve.py and the wide set of test_e2e.py
cases listed) from llm_function_core.txt into llm_function_full.txt (or another
appropriate QA list), and update the PR description to state which tests remain
in core vs moved so reviewers know the change intent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ce0c938f-ae46-45f2-b17e-e08644856bc7
📒 Files selected for processing (14)
tests/integration/test_lists/qa/llm_function_core.txttests/integration/test_lists/qa/llm_function_l20.txttests/integration/test_lists/qa/llm_function_rtx6k.txttests/integration/test_lists/qa/llm_spark_core.txttests/integration/test_lists/qa/llm_spark_func.ymltests/integration/test_lists/qa/llm_triton_integration.txttests/integration/test_lists/test-db/l0_a30.ymltests/integration/test_lists/test-db/l0_b200.ymltests/integration/test_lists/test-db/l0_dgx_h100.ymltests/integration/test_lists/test-db/l0_dgx_h200.ymltests/integration/test_lists/test-db/l0_gb203.ymltests/integration/test_lists/test-db/l0_h100.ymltests/integration/test_lists/test-db/l0_l40s.ymltests/integration/test_lists/test-db/l0_rtx_pro_6000.yml
💤 Files with no reviewable changes (13)
- tests/integration/test_lists/test-db/l0_b200.yml
- tests/integration/test_lists/test-db/l0_gb203.yml
- tests/integration/test_lists/qa/llm_spark_core.txt
- tests/integration/test_lists/test-db/l0_l40s.yml
- tests/integration/test_lists/qa/llm_function_l20.txt
- tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml
- tests/integration/test_lists/test-db/l0_a30.yml
- tests/integration/test_lists/test-db/l0_h100.yml
- tests/integration/test_lists/test-db/l0_dgx_h200.yml
- tests/integration/test_lists/test-db/l0_dgx_h100.yml
- tests/integration/test_lists/qa/llm_spark_func.yml
- tests/integration/test_lists/qa/llm_function_rtx6k.txt
- tests/integration/test_lists/qa/llm_triton_integration.txt
|
PR_Github #44659 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "" |
|
PR_Github #44663 [ run ] triggered by Bot. Commit: |
|
PR_Github #44659 [ run ] completed with state |
|
PR_Github #44663 [ run ] completed with state
|
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run --stage-list "" |
|
/bot run --skip-test |
1 similar comment
|
/bot run --skip-test |
|
PR_Github #44892 [ run ] triggered by Bot. Commit: |
|
PR_Github #44892 [ run ] completed with state |
|
/bot reuse-pipeline |
|
PR_Github #44954 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #44954 [ reuse-pipeline ] completed with state |
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.