Skip to content

[TRTLLM-13947][test] Retire Triton backend TRT workflow QA tests - #15814

Merged
StanleySun639 merged 1 commit into
NVIDIA:mainfrom
StanleySun639:delete_triton_backend_trt_workflow_QA_tests
Jul 3, 2026
Merged

[TRTLLM-13947][test] Retire Triton backend TRT workflow QA tests#15814
StanleySun639 merged 1 commit into
NVIDIA:mainfrom
StanleySun639:delete_triton_backend_trt_workflow_QA_tests

Conversation

@StanleySun639

@StanleySun639 StanleySun639 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Reduced the Triton integration test set to a smaller, more focused group of LLM API scenarios.
    • Removed several older or unused integration checks and related test helpers.
    • Updated test selection lists and waivers to match the streamlined coverage.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@StanleySun639
StanleySun639 requested review from a team as code owners July 1, 2026 03:34
@StanleySun639
StanleySun639 force-pushed the delete_triton_backend_trt_workflow_QA_tests branch from 61f6905 to e06075d Compare July 1, 2026 03:36
@StanleySun639

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e36e2ff0-f36b-476d-bc9e-7ed5495d11fd

📥 Commits

Reviewing files that changed from the base of the PR and between 066a201 and 61f6905.

📒 Files selected for processing (9)
  • tests/integration/defs/triton_server/build_engines.py
  • tests/integration/defs/triton_server/rcca/bug_4323566/inflight_batcher_llm_client_with_end_id.py
  • tests/integration/defs/triton_server/test_triton_llm.py
  • tests/integration/defs/triton_server/test_triton_memleak.py
  • tests/integration/defs/triton_server/test_triton_multi_node.py
  • tests/integration/defs/triton_server/test_triton_rcca.py
  • tests/integration/test_lists/qa/llm_triton_integration.txt
  • tests/integration/test_lists/test-db/l0_a30.yml
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (7)
  • tests/integration/test_lists/qa/llm_triton_integration.txt
  • tests/integration/defs/triton_server/test_triton_multi_node.py
  • tests/integration/defs/triton_server/test_triton_memleak.py
  • tests/integration/defs/triton_server/rcca/bug_4323566/inflight_batcher_llm_client_with_end_id.py
  • tests/integration/test_lists/waives.txt
  • tests/integration/defs/triton_server/test_triton_rcca.py
  • tests/integration/defs/triton_server/build_engines.py

📝 Walkthrough

Walkthrough

This PR removes legacy Triton server integration test files, including engine-building helpers, RCCA client scripts, memory leak tests, multi-node tests, and general RCCA tests. It also trims the QA test list, test-db manifest, and waivers file to retain only a small set of Triton LLM API backend tests.

Changes

Triton test suite removal and list trimming

Layer / File(s) Summary
Remove Triton engine-building helpers and client scripts
tests/integration/defs/triton_server/build_engines.py, tests/integration/defs/triton_server/rcca/bug_4323566/inflight_batcher_llm_client_with_end_id.py
Deletes all engine preparation functions for numerous model variants and the GRPC client script used for RCCA bug 4323566 testing.
Remove Triton integration test modules
tests/integration/defs/triton_server/test_triton_memleak.py, tests/integration/defs/triton_server/test_triton_multi_node.py, tests/integration/defs/triton_server/test_triton_rcca.py
Deletes memory leak, multi-node, and RCCA regression test modules along with their fixtures and test functions.
Trim QA/test-db lists and waivers
tests/integration/test_lists/qa/llm_triton_integration.txt, tests/integration/test_lists/test-db/l0_a30.yml, tests/integration/test_lists/waives.txt
Reduces test manifests to six remaining test_llmapi_backend/test_llmapi_lora/test_llmapi_backend_multi_instance entries and removes two obsolete waiver lines.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#13262: Both PRs edit tests/integration/test_lists/qa/llm_triton_integration.txt to drop numerous Triton model-parameter test combinations.

Suggested reviewers: jieli-matrix, chzblych, niukuo, EmmaQiaoCh

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description keeps the template but leaves the required Description and Test Coverage sections empty. Add a short Description of what was removed and why, plus Test Coverage with the relevant tests or note if none were run.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and clearly states that Triton backend TRT workflow QA tests are being retired.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56816 [ run ] triggered by Bot. Commit: e06075d Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56816 [ run ] completed with state SUCCESS. Commit: e06075d
/LLM/main/L0_MergeRequest_PR pipeline #45632 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@StanleySun639
StanleySun639 force-pushed the delete_triton_backend_trt_workflow_QA_tests branch from e06075d to 5efba46 Compare July 1, 2026 10:18
@StanleySun639

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56909 [ run ] triggered by Bot. Commit: 5efba46 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56909 [ run ] completed with state SUCCESS. Commit: 5efba46
/LLM/main/L0_MergeRequest_PR pipeline #45713 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@StanleySun639
StanleySun639 force-pushed the delete_triton_backend_trt_workflow_QA_tests branch from 5efba46 to 3b85841 Compare July 2, 2026 01:37

@fredricz-20070104 fredricz-20070104 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@StanleySun639
StanleySun639 requested review from QiJune and Tabrizian July 2, 2026 01:41
@StanleySun639
StanleySun639 force-pushed the delete_triton_backend_trt_workflow_QA_tests branch from 3b85841 to 2e7b2b3 Compare July 2, 2026 01:41
@StanleySun639

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57059 [ run ] triggered by Bot. Commit: 2e7b2b3 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57059 [ run ] completed with state SUCCESS. Commit: 2e7b2b3
/LLM/main/L0_MergeRequest_PR pipeline #45852 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@StanleySun639
StanleySun639 force-pushed the delete_triton_backend_trt_workflow_QA_tests branch from 2e7b2b3 to 9030c9c Compare July 2, 2026 11:35
@StanleySun639

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list ""

@StanleySun639
StanleySun639 force-pushed the delete_triton_backend_trt_workflow_QA_tests branch from 9030c9c to ba9984d Compare July 3, 2026 01:18
@StanleySun639

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list ""

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57289 [ run ] triggered by Bot. Commit: ba9984d Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57289 [ run ] completed with state FAILURE. Commit: ba9984d
/LLM/main/L0_MergeRequest_PR pipeline #46048 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@StanleySun639
StanleySun639 force-pushed the delete_triton_backend_trt_workflow_QA_tests branch from ba9984d to 4717b57 Compare July 3, 2026 01:48
@StanleySun639

Copy link
Copy Markdown
Collaborator Author

/bot run --skip-test

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57302 [ run ] triggered by Bot. Commit: 4717b57 Link to invocation

@StanleySun639
StanleySun639 enabled auto-merge (squash) July 3, 2026 02:22
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57302 [ run ] completed with state FAILURE. Commit: 4717b57
/LLM/main/L0_MergeRequest_PR pipeline #46061 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: Stanley Sun <stsun@nvidia.com>
@StanleySun639
StanleySun639 force-pushed the delete_triton_backend_trt_workflow_QA_tests branch from 4717b57 to c16f1dd Compare July 3, 2026 03:52
@StanleySun639

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list ""

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57346 [ run ] triggered by Bot. Commit: c16f1dd Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57346 [ run ] completed with state SUCCESS. Commit: c16f1dd
/LLM/main/L0_MergeRequest_PR pipeline #46102 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@StanleySun639

Copy link
Copy Markdown
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57398 [ reuse-pipeline ] triggered by Bot. Commit: c16f1dd Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57398 [ reuse-pipeline ] completed with state SUCCESS. Commit: c16f1dd
Reusing PR_Github #57346 (Partly Tested) for commit c16f1dd

Link to invocation

@StanleySun639
StanleySun639 merged commit ca9c439 into NVIDIA:main Jul 3, 2026
7 checks passed
@StanleySun639
StanleySun639 deleted the delete_triton_backend_trt_workflow_QA_tests branch July 3, 2026 07:39
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants