[https://nvbugs/6143787][fix] Add kv_cache_config = KvCacheConfig(free_gpu_memory_fraction=0.6) to TestQwen3 - #13852
Conversation
📝 WalkthroughWalkthroughTestQwen3VL test class adds a KV cache configuration with 60% free GPU memory allocation and applies it to the test_auto_dtype LLM instantiation. A corresponding waiver entry for the Qwen3VL test is removed while a new waiver for a Qwen3.5 35B test is added to the test waiver list. ChangesKV Cache Configuration for Qwen3VL Tests
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/defs/accuracy/test_llm_api_pytorch_multimodal.py (1)
420-437: QA list update looks unnecessary for this diff.This is a stability tweak to an existing integration test definition, not a new scheduled test case, so no QA test-list entry change is needed in this file.
As per coding guidelines: "If the change adds or materially alters an integration test under tests/integration/defs/ ... call out whether an entry is needed under tests/integration/test_lists/qa/."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/defs/accuracy/test_llm_api_pytorch_multimodal.py` around lines 420 - 437, The change is a stability tweak to the existing integration test (test_auto_dtype) and should not add or modify QA test-list entries; remove or revert any edits that created/updated a QA entry for this test case and ensure no new entry is added under the QA test lists for this change, leaving the test function test_auto_dtype, the LLM(...) instantiation, and the MMMU(self.MODEL_NAME).evaluate(...) call as the only modifications in this diff.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/defs/accuracy/test_llm_api_pytorch_multimodal.py`:
- Around line 420-437: The change is a stability tweak to the existing
integration test (test_auto_dtype) and should not add or modify QA test-list
entries; remove or revert any edits that created/updated a QA entry for this
test case and ensure no new entry is added under the QA test lists for this
change, leaving the test function test_auto_dtype, the LLM(...) instantiation,
and the MMMU(self.MODEL_NAME).evaluate(...) call as the only modifications in
this diff.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3314a292-bdc3-4890-9ae0-b9cc1531c236
📒 Files selected for processing (2)
tests/integration/defs/accuracy/test_llm_api_pytorch_multimodal.pytests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
- tests/integration/test_lists/waives.txt
|
/bot run |
|
PR_Github #47312 [ run ] triggered by Bot. Commit: |
|
PR_Github #47312 [ run ] completed with state
|
529046f to
e321ce2
Compare
e321ce2 to
83ff5ed
Compare
|
/bot run |
|
PR_Github #50572 [ run ] triggered by Bot. Commit: |
|
PR_Github #50572 [ run ] completed with state |
3975ccc to
ee3d9a9
Compare
|
/bot run |
|
PR_Github #51378 [ run ] triggered by Bot. Commit: |
|
PR_Github #51378 [ run ] completed with state
|
|
/bot run |
|
PR_Github #51748 [ run ] triggered by Bot. Commit: |
|
PR_Github #51748 [ run ] completed with state
|
…d OOM on L40S TestQwen3VL.test_auto_dtype had no KvCacheConfig override, so the default free_gpu_memory_fraction (~0.9) caused OOM during attention workspace allocation on 48GB GPUs. Match the sister TestQwen2_5_VL_7B pattern by setting free_gpu_memory_fraction=0.6. Remove the corresponding waiver. Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
ee3d9a9 to
026ead0
Compare
|
/bot run |
|
PR_Github #52171 [ run ] triggered by Bot. Commit: |
|
PR_Github #52171 [ run ] completed with state |
…ee_gpu_memory_fraction=0.6)` to TestQwen3 (NVIDIA#13852) Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com> Signed-off-by: NVFB <186336021+NVFB@users.noreply.github.com>
…ee_gpu_memory_fraction=0.6)` to TestQwen3 (NVIDIA#13852) Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Summary
kv_cache_config = KvCacheConfig(free_gpu_memory_fraction=0.6)to TestQwen3VL and pass it to LLM(); remove the stale skip waiver.Test plan
Links
Summary by CodeRabbit
Tests
Chores