[https://nvbugs/6276841][fix] When torch_compile=True, pass kv_cache_config=KvCacheConfig(free_gpu_memory_fra… - #15095
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR adjusts the Qwen 3 30B A3B Instruct test configuration to prevent out-of-memory during fp8 precision test execution when torch_compile is enabled. The KV-cache memory fraction is conditionally reduced from default to 0.6 to provide workspace for CUDA-graph capture, and the corresponding test waiver is removed since the configuration change allows the test to pass. ChangesKV-cache memory adjustment for torch_compile
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #52898 [ run ] triggered by Bot. Commit: |
|
PR_Github #52898 [ run ] completed with state
|
|
/bot run |
|
PR_Github #53419 [ run ] triggered by Bot. Commit: |
|
PR_Github #53419 [ run ] completed with state
|
|
/bot run |
|
PR_Github #53734 [ run ] triggered by Bot. Commit: |
|
PR_Github #53734 [ run ] completed with state |
|
/bot run |
|
PR_Github #54226 [ run ] triggered by Bot. Commit: |
|
PR_Github #54226 [ run ] completed with state
|
…fp8 with torch_compile Piecewise CUDA-graph capture under torch_compile=True needs additional GPU workspace beyond what the default kv_cache fraction (0.9) reserves on the 44 GiB L40S. As a result, _capture_piecewise_cuda_graphs OOMs in the executor_extra stage during executor creation. Mirror the established fix from NVIDIA#14109 (nvbugs/6162860, TestDeepSeekV3Lite): when torch_compile=True, set free_gpu_memory_fraction=0.6 so the executor has room for graph workspace. The non-compile path keeps the default and already passes. Also remove the now-obsolete L40S waiver for this test. Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
5a514e8 to
2e936b6
Compare
Signed-off-by: bhsueh <11360707+byshiue@users.noreply.github.com> # Conflicts: # tests/integration/defs/accuracy/test_llm_api_pytorch.py # tests/integration/test_lists/waives.txt
|
/bot run |
|
PR_Github #55938 [ run ] triggered by Bot. Commit: |
|
PR_Github #55938 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #56018 [ run ] triggered by Bot. Commit: |
|
PR_Github #56018 [ run ] completed with state
|
|
/bot run |
|
PR_Github #56246 [ run ] triggered by Bot. Commit: |
|
PR_Github #56246 [ run ] completed with state
|
|
/bot run |
1 similar comment
|
/bot run |
|
PR_Github #56773 [ run ] triggered by Bot. Commit: |
|
PR_Github #56773 [ run ] completed with state
|
|
/bot run --disable-cbts |
|
PR_Github #59832 [ run ] triggered by Bot. Commit: |
|
PR_Github #59832 [ run ] completed with state
|
|
/bot run --disable-cbts |
|
PR_Github #60206 [ run ] triggered by Bot. Commit: |
|
PR_Github #60206 [ run ] completed with state
|
Signed-off-by: bhsueh <11360707+byshiue@users.noreply.github.com> # Conflicts: # tests/integration/test_lists/waives.txt
|
/bot run --disable-cbts |
|
PR_Github #60523 [ run ] triggered by Bot. Commit: |
|
PR_Github #60523 [ run ] completed with state
|
| # 44 GiB L40S; lower the fraction in that case to avoid executor OOM. | ||
| if torch_compile: | ||
| pytorch_config["kv_cache_config"] = KvCacheConfig( | ||
| free_gpu_memory_fraction=0.6) |
There was a problem hiding this comment.
this may affect perf value for other models
Summary
Test plan
Links
Summary by CodeRabbit