Skip to content

[https://nvbugs/6140422][fix] Unwaive K25 Disagg DEP Test - #14139

Merged
chenfeiz0326 merged 1 commit into
NVIDIA:mainfrom
chenfeiz0326:chenfeiz/unwaive-k25-dep-disagg
May 14, 2026
Merged

[https://nvbugs/6140422][fix] Unwaive K25 Disagg DEP Test#14139
chenfeiz0326 merged 1 commit into
NVIDIA:mainfrom
chenfeiz0326:chenfeiz/unwaive-k25-dep-disagg

Conversation

@chenfeiz0326

@chenfeiz0326 chenfeiz0326 commented May 14, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Re-enabled a previously waived test case to be included in future test runs.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
@chenfeiz0326
chenfeiz0326 requested a review from ZhanruiSunCh May 14, 2026 09:59
@chenfeiz0326
chenfeiz0326 requested a review from reasonsolo May 14, 2026 09:59
@chenfeiz0326
chenfeiz0326 enabled auto-merge (squash) May 14, 2026 10:00
@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

A single waived test entry for a perf sanity parameterized test case is removed from tests/integration/test_lists/waives.txt, allowing that specific test to run without being skipped.

Changes

Test waiver list maintenance

Layer / File(s) Summary
Remove perf sanity test waiver entry
tests/integration/test_lists/waives.txt
The waiver entry for perf/test_perf_sanity.py::test_e2e[disagg_upload-gen_only-gb200_kimi-k25-thinking-...] is removed from the integration test waives list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14131: Both PRs modify the same file tests/integration/test_lists/waives.txt by removing/adding specific waived test entries.
  • NVIDIA/TensorRT-LLM#14094: Both PRs modify the same integration waive list file with different waived test entry changes.
  • NVIDIA/TensorRT-LLM#14119: Both PRs update tests/integration/test_lists/waives.txt to remove/modify specific waived test cases.

Suggested reviewers

  • niukuo
  • jieli-matrix
  • xinhe-nv
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template with no concrete details filled in about the issue, solution, or test coverage. Fill in the Description and Test Coverage sections with specific details about why the test waiver was removed and how it was tested.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: removing a waived test entry for the K25 disaggregation DEP test case.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@chenfeiz0326 chenfeiz0326 changed the title [None][test] Unwaive K25 Disagg DEP Case [https://nvbugs/6140422][fix] Fix some bugs Unwaive K25 Disagg DEP Case May 14, 2026
@chenfeiz0326 chenfeiz0326 changed the title [https://nvbugs/6140422][fix] Fix some bugs Unwaive K25 Disagg DEP Case [https://nvbugs/6140422][fix] Unwaive K25 Disagg DEP Case May 14, 2026
@chenfeiz0326 chenfeiz0326 changed the title [https://nvbugs/6140422][fix] Unwaive K25 Disagg DEP Case [https://nvbugs/6140422][fix] Unwaive K25 Disagg DEP Test May 14, 2026
@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Only unwaive perf tests, no need to run the whole CI pipeline"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #48372 [ skip ] triggered by Bot. Commit: b7a3984 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #48372 [ skip ] completed with state SUCCESS. Commit: b7a3984
Skipping testing for commit b7a3984

Link to invocation

@chenfeiz0326
chenfeiz0326 merged commit b9e1945 into NVIDIA:main May 14, 2026
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants