Skip to content

[https://nvbugs/6027594][fix] Unwaive testcase - #14383

Merged
YihuiLu512 merged 1 commit into
NVIDIA:mainfrom
YihuiLu512:dev-fix-06-J-N6027594
May 21, 2026
Merged

[https://nvbugs/6027594][fix] Unwaive testcase#14383
YihuiLu512 merged 1 commit into
NVIDIA:mainfrom
YihuiLu512:dev-fix-06-J-N6027594

Conversation

@YihuiLu512

@YihuiLu512 YihuiLu512 commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Removed a test waiver to enable validation of previously exempted test scenarios with specific parameter configurations.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Yihui Lu <269394165+YihuiLu512@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6b89a274-8426-4746-90a5-f886bd478372

📥 Commits

Reviewing files that changed from the base of the PR and between 67b0654 and 597d471.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR removes a single test waiver entry from tests/integration/test_lists/waives.txt for the TestDeepSeekV3Lite::test_bfloat16 test case with specific parameters, indicating the test no longer requires an exemption.

Changes

Test Waiver Removal

Layer / File(s) Summary
Remove DeepSeekV3Lite::test_bfloat16 waiver
tests/integration/test_lists/waives.txt
Removes the SKIP waiver entry for TestDeepSeekV3Lite::test_bfloat16 with parameters mtp_nextn=0, torch_compile=True, and v2_kv_cache=False (referenced by nvbug 6027594).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • pengbowang-nv
  • chzblych
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete, containing only the template with no actual explanation of changes, rationale, or test coverage details. Add a clear description of why the waiver is being removed, what issue it resolves, and confirm the relevant test now passes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title correctly follows the required format with NVBugs ID and fix type, clearly summarizing the main change of removing a test waiver.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@YihuiLu512

Copy link
Copy Markdown
Collaborator Author

/bot run

@YihuiLu512
YihuiLu512 requested a review from pengbowang-nv May 21, 2026 04:18
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49584 [ run ] triggered by Bot. Commit: 597d471 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49584 [ run ] completed with state SUCCESS. Commit: 597d471
/LLM/main/L0_MergeRequest_PR pipeline #39209 completed with status: 'SUCCESS'

CI Report

Link to invocation

@YihuiLu512
YihuiLu512 merged commit 31d68b2 into NVIDIA:main May 21, 2026
11 checks passed
xxi-nv pushed a commit to xxi-nv/TensorRT-LLM that referenced this pull request May 22, 2026
Signed-off-by: Yihui Lu <269394165+YihuiLu512@users.noreply.github.com>
KleinBlueC pushed a commit to KleinBlueC/TensorRT-LLM that referenced this pull request May 26, 2026
Signed-off-by: Yihui Lu <269394165+YihuiLu512@users.noreply.github.com>
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
Signed-off-by: Yihui Lu <269394165+YihuiLu512@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants