[None][fix] Remove duplicate indexer_k_dtype kwarg in DSv4 sparse attention config - #14302
Closed
taizhongw wants to merge 1 commit into
Closed
Conversation
…tion config PR NVIDIA#14219 added indexer_k_dtype to the dict returned by update_sparse_attention_indexer_config(), but the DSv4 code path also passes it as an explicit keyword argument. This causes TypeError: got multiple values for keyword argument 'indexer_k_dtype' when loading DeepSeek-V4 models. Remove the redundant explicit argument since it is already included in the indexer_config dict via **indexer_config. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
taizhongw
marked this pull request as ready for review
May 19, 2026 14:51
taizhongw
requested review from
HuiGao-NV and
leslie-fang25
and removed request for
a team
May 19, 2026 14:51
lfr-0531
changed the title
Collaborator
|
This issue was fixed in #14321. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion config
PR #14219 added indexer_k_dtype to the dict returned by update_sparse_attention_indexer_config(), but the DSv4 code path also passes it as an explicit keyword argument. This causes TypeError: got multiple values for keyword argument 'indexer_k_dtype' when loading DeepSeek-V4 models.
Remove the redundant explicit argument since it is already included in the indexer_config dict via **indexer_config.
@coderabbitai summary
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.