[None][fix] DSv4: drop duplicate indexer_k_dtype kwarg on V4 sparse attn#14321
Merged
lfr-0531 merged 1 commit intoMay 20, 2026
Conversation
indexer_k_dtype is already populated inside indexer_config by update_sparse_attention_indexer_config (which sources it from sparse_attention_config.indexer_k_dtype, falling back to the "fp8" default). Passing it again as an explicit kwarg to DeepSeekV4SparseAttentionConfig while also expanding **indexer_config triggers a duplicate keyword argument TypeError during executor init. Drop the explicit kwarg and let **indexer_config provide the value. Signed-off-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com>
Member
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #49258 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #49258 [ run ] completed with state |
1 task
lfr-0531
pushed a commit
to lfr-0531/TensorRT-LLM
that referenced
this pull request
May 29, 2026
…ttn (NVIDIA#14321) Signed-off-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com> (cherry picked from commit 349f087) Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
lfr-0531
pushed a commit
to lfr-0531/TensorRT-LLM
that referenced
this pull request
Jun 1, 2026
…ttn (NVIDIA#14321) Signed-off-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com> (cherry picked from commit 349f087) Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
lfr-0531
pushed a commit
to lfr-0531/TensorRT-LLM
that referenced
this pull request
Jun 3, 2026
…ttn (NVIDIA#14321) Signed-off-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com> (cherry picked from commit 349f087) Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
lfr-0531
pushed a commit
to lfr-0531/TensorRT-LLM
that referenced
this pull request
Jun 7, 2026
…ttn (NVIDIA#14321) Signed-off-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com> (cherry picked from commit 349f087) Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
lfr-0531
pushed a commit
to lfr-0531/TensorRT-LLM
that referenced
this pull request
Jun 10, 2026
…ttn (NVIDIA#14321) Signed-off-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com>
lfr-0531
pushed a commit
to lfr-0531/TensorRT-LLM
that referenced
this pull request
Jun 11, 2026
…ttn (NVIDIA#14321) Signed-off-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com>
lfr-0531
pushed a commit
to lfr-0531/TensorRT-LLM
that referenced
this pull request
Jun 12, 2026
…ttn (NVIDIA#14321) Signed-off-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com>
lfr-0531
pushed a commit
to lfr-0531/TensorRT-LLM
that referenced
this pull request
Jun 12, 2026
…ttn (NVIDIA#14321) Signed-off-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com> (cherry picked from commit 349f087) Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
lfr-0531
pushed a commit
to lfr-0531/TensorRT-LLM
that referenced
this pull request
Jun 13, 2026
…ttn (NVIDIA#14321) Signed-off-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com> (cherry picked from commit 349f087) Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
lfr-0531
pushed a commit
to lfr-0531/TensorRT-LLM
that referenced
this pull request
Jun 16, 2026
…ttn (NVIDIA#14321) Signed-off-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com> (cherry picked from commit 349f087) Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
lfr-0531
pushed a commit
to lfr-0531/TensorRT-LLM
that referenced
this pull request
Jun 17, 2026
…ttn (NVIDIA#14321) Signed-off-by: Iman Tabrizian <10105175+Tabrizian@users.noreply.github.com> (cherry picked from commit 349f087) Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indexer_k_dtype is already populated inside indexer_config by update_sparse_attention_indexer_config (which sources it from sparse_attention_config.indexer_k_dtype, falling back to the "fp8" default). Passing it again as an explicit kwarg to DeepSeekV4SparseAttentionConfig while also expanding **indexer_config triggers a duplicate keyword argument TypeError during executor init. Drop the explicit kwarg and let **indexer_config provide the value.
@coderabbitai summary
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.