Skip to content

[None][infra] Update blossom-ci allowlist: fix jdebache - #14304

Merged
yiqingy0 merged 1 commit into
NVIDIA:mainfrom
yiqingy0:update_user_in_allowlist
May 20, 2026
Merged

[None][infra] Update blossom-ci allowlist: fix jdebache#14304
yiqingy0 merged 1 commit into
NVIDIA:mainfrom
yiqingy0:update_user_in_allowlist

Conversation

@yiqingy0

@yiqingy0 yiqingy0 commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated authorization configuration in the CI/CD pipeline.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
@yiqingy0
yiqingy0 requested a review from a team May 19, 2026 11:12
@yiqingy0
yiqingy0 requested a review from a team as a code owner May 19, 2026 11:12
@yiqingy0
yiqingy0 requested review from tburt-nv and yuanjingx87 May 19, 2026 11:12
@yiqingy0

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Only change allowlist"

@yiqingy0
yiqingy0 requested a review from niukuo May 19, 2026 11:16
@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The Blossom-CI workflow authorization allowlist in .github/workflows/blossom-ci.yml was updated by replacing the authorized username hypdeb with jdebache in the Authorization job's actor check.

Changes

CI Authorization Update

Layer / File(s) Summary
CI authorization allowlist update
.github/workflows/blossom-ci.yml
The authorized-actor allowlist in the Authorization job's if condition was updated: the username entry hypdeb was replaced with jdebache.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14295: Both PRs modify .github/workflows/blossom-ci.yml's Authorization job actor allowlist by changing the hardcoded permitted usernames.
  • NVIDIA/TensorRT-LLM#14132: Both PRs modify the same Blossom-CI workflow Authorization job allowlist by changing the hardcoded permitted github.actor username.

Suggested reviewers

  • yuanjingx87
  • niukuo
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely empty, containing only the template structure with no actual content filled in for Description, Test Coverage, or meaningful checklist responses. Fill in the Description section explaining why 'hypdeb' was replaced with 'jdebache' in the allowlist, and provide Test Coverage details for how this authorization change was validated.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating the blossom-ci allowlist to replace a username, with the [infra] type indicating infrastructure changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/blossom-ci.yml (1)

144-144: ⚡ Quick win

Username is out of alphabetical order.

The entry "jdebache" is placed between "hvagadia" (line 143) and "hyukn" (line 145), breaking the alphabetical sorting of the allowlist. To maintain consistency and ease future maintenance, "jdebache" should be moved to its correct alphabetical position after "hyukn" and before other 'j' entries starting around line 150.

📋 Suggested fix to restore alphabetical order

Remove "jdebache" from line 144 and place it in the correct alphabetical position:

         "hvagadia",
-        "jdebache",
         "hyukn",

Then add it after line 145 in its correct position (between "hyukn" and other 'j' entries that start around line 150):

         "hyukn",
+        "jdebache",
         "indrajit96",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/blossom-ci.yml at line 144, The allowlist entry "jdebache"
is out of alphabetical order between "hvagadia" and "hyukn"; remove the
"jdebache" line where it currently appears and re-insert it after the "hyukn"
entry (i.e., before the block of 'j' usernames) so the list is strictly
alphabetized.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/blossom-ci.yml:
- Line 144: The allowlist entry "jdebache" is out of alphabetical order between
"hvagadia" and "hyukn"; remove the "jdebache" line where it currently appears
and re-insert it after the "hyukn" entry (i.e., before the block of 'j'
usernames) so the list is strictly alphabetized.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6265bcd8-7024-491d-910d-1947f1c821bb

📥 Commits

Reviewing files that changed from the base of the PR and between 989671b and ca51ed2.

📒 Files selected for processing (1)
  • .github/workflows/blossom-ci.yml

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49179 [ skip ] triggered by Bot. Commit: ca51ed2 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49179 [ skip ] completed with state SUCCESS. Commit: ca51ed2
Skipping testing for commit ca51ed2

Link to invocation

@yiqingy0
yiqingy0 merged commit 9f90361 into NVIDIA:main May 20, 2026
12 of 14 checks passed
@yiqingy0
yiqingy0 deleted the update_user_in_allowlist branch May 20, 2026 02:20
xxi-nv pushed a commit to xxi-nv/TensorRT-LLM that referenced this pull request May 22, 2026
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Co-authored-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Co-authored-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants