[None][infra] Update blossom-ci allowlist: fix jdebache - #14304
Conversation
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
|
/bot skip --comment "Only change allowlist" |
📝 WalkthroughWalkthroughThe Blossom-CI workflow authorization allowlist in ChangesCI Authorization Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/blossom-ci.yml (1)
144-144: ⚡ Quick winUsername is out of alphabetical order.
The entry
"jdebache"is placed between"hvagadia"(line 143) and"hyukn"(line 145), breaking the alphabetical sorting of the allowlist. To maintain consistency and ease future maintenance,"jdebache"should be moved to its correct alphabetical position after"hyukn"and before other 'j' entries starting around line 150.📋 Suggested fix to restore alphabetical order
Remove
"jdebache"from line 144 and place it in the correct alphabetical position:"hvagadia", - "jdebache", "hyukn",Then add it after line 145 in its correct position (between "hyukn" and other 'j' entries that start around line 150):
"hyukn", + "jdebache", "indrajit96",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/blossom-ci.yml at line 144, The allowlist entry "jdebache" is out of alphabetical order between "hvagadia" and "hyukn"; remove the "jdebache" line where it currently appears and re-insert it after the "hyukn" entry (i.e., before the block of 'j' usernames) so the list is strictly alphabetized.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/blossom-ci.yml:
- Line 144: The allowlist entry "jdebache" is out of alphabetical order between
"hvagadia" and "hyukn"; remove the "jdebache" line where it currently appears
and re-insert it after the "hyukn" entry (i.e., before the block of 'j'
usernames) so the list is strictly alphabetized.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6265bcd8-7024-491d-910d-1947f1c821bb
📒 Files selected for processing (1)
.github/workflows/blossom-ci.yml
|
PR_Github #49179 [ skip ] triggered by Bot. Commit: |
|
PR_Github #49179 [ skip ] completed with state |
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com> Co-authored-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com> Co-authored-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.