Skip to content

[None][infra] Revert Mingyang back to mingyangHao in allowlist - #14349

Merged
ZhanruiSunCh merged 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:user/zhanruis/add_users_to_allowlist
May 20, 2026
Merged

[None][infra] Revert Mingyang back to mingyangHao in allowlist#14349
ZhanruiSunCh merged 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:user/zhanruis/add_users_to_allowlist

Conversation

@ZhanruiSunCh

@ZhanruiSunCh ZhanruiSunCh commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated internal CI/CD authorization configuration to reflect changes in access control for the workflow pipeline.

Note: This is an internal infrastructure update with no user-facing impact.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
@ZhanruiSunCh
ZhanruiSunCh requested a review from a team May 20, 2026 08:46
@ZhanruiSunCh
ZhanruiSunCh requested a review from a team as a code owner May 20, 2026 08:46
@ZhanruiSunCh
ZhanruiSunCh requested a review from niukuo May 20, 2026 08:46
@ZhanruiSunCh

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Only change allowlist"

@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5887399e-44ec-4697-964b-eabda6bf9476

📥 Commits

Reviewing files that changed from the base of the PR and between 9e3dbaa and 354299f.

📒 Files selected for processing (1)
  • .github/workflows/blossom-ci.yml

📝 Walkthrough

Walkthrough

The GitHub Actions CI workflow's Authorization job allowlist is updated to replace the actor "Mingyang" with "mingyangHao", changing which GitHub users are authorized to trigger the workflow via the actor gating condition.

Changes

CI Authorization Allowlist

Layer / File(s) Summary
Authorization actor allowlist update
.github/workflows/blossom-ci.yml
The allowed-actors list in the Authorization job is updated from "Mingyang" to "mingyangHao", changing the outcome of the actor authorization check used to gate workflow execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14132: Updates the same authorization allowlist by adding "mingyangHao", with overlapping intent to include this actor in workflow authorization.
  • NVIDIA/TensorRT-LLM#14295: Modifies the same Authorization job actor allowlist and also adds other authorized actors to the gating condition.
  • NVIDIA/TensorRT-LLM#14304: Updates the same .github/workflows/blossom-ci.yml Authorization job allowlist with a similar actor username change.

Suggested reviewers

  • yuanjingx87
  • niukuo
  • tburt-nv
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. Critical sections (Description, Test Coverage) are empty, and only the template header with the checklist checkbox is filled. Add a Description section explaining the reason for reverting the username, and provide Test Coverage details or clarify why none are needed for this infrastructure change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: reverting 'Mingyang' to 'mingyangHao' in the allowlist with appropriate type tag [infra].
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49399 [ skip ] triggered by Bot. Commit: 354299f Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49399 [ skip ] completed with state SUCCESS. Commit: 354299f
Skipping testing for commit 354299f

Link to invocation

@ZhanruiSunCh
ZhanruiSunCh enabled auto-merge (squash) May 20, 2026 09:00
@ZhanruiSunCh
ZhanruiSunCh merged commit c71655e into NVIDIA:main May 20, 2026
14 of 15 checks passed
xxi-nv pushed a commit to xxi-nv/TensorRT-LLM that referenced this pull request May 22, 2026
…A#14349)

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
…A#14349)

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants