Skip to content

[https://nvbugs/6191544][chore] Waive failing perf tests to unblock L0 - #14382

Closed
galagam wants to merge 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:gagam/6191544-waive
Closed

[https://nvbugs/6191544][chore] Waive failing perf tests to unblock L0#14382
galagam wants to merge 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:gagam/6191544-waive

Conversation

@galagam

@galagam galagam commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Added test waiver entries for performance sanity checks on specific hardware configurations.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
@galagam
galagam requested a review from dc3671 May 21, 2026 04:12
@galagam

galagam commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 43af7727-bac7-4b2a-bcf0-9e11b370221d

📥 Commits

Reviewing files that changed from the base of the PR and between 67b0654 and b3dc127.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR adds two test waiver entries to the integration test skip list, marking perf/test_perf_sanity.py::test_e2e as skipped for GB200 Deepseek R1 and Qwen3 model configurations under aggregated upload context-only scenarios, both referencing nvbugs/6191544.

Changes

Test Performance Sanity Waivers

Layer / File(s) Summary
GB200 performance test waivers
tests/integration/test_lists/waives.txt
Two SKIP waiver entries added for perf/test_perf_sanity.py::test_e2e on gb200_deepseek-r1-fp4_... and gb200_qwen3-235b-fp4_... under aggr_upload-ctx_only (NIXL), both linked to nvbugs/6191544.

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14316: Adds SKIP waiver entries to the same test waivers file for perf/test_perf_sanity.py::test_e2e.
  • NVIDIA/TensorRT-LLM#14346: Adds SKIP waivers to tests/integration/test_lists/waives.txt for the same test on gb200_* aggr_upload-ctx_only configurations.
  • NVIDIA/TensorRT-LLM#14294: Modifies the same waiver list file by adding perf/test_perf_sanity.py::test_e2e skip entries for aggr_upload-* configurations.

Suggested reviewers

  • tburt-nv
  • yiqingy0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete; it contains only the template structure with empty sections for Description and Test Coverage, lacking the required explanations of issue, solution, and test details. Fill in the Description section explaining why the perf tests are being waived, and list the relevant test cases under Test Coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: adding waiver entries for failing perf tests to unblock L0, with the NVBugs ticket properly referenced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49581 [ run ] triggered by Bot. Commit: b3dc127 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49581 [ run ] completed with state SUCCESS. Commit: b3dc127
/LLM/main/L0_MergeRequest_PR pipeline #39206 completed with status: 'SUCCESS'

CI Report

Link to invocation

@galagam

galagam commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

Fixed on ToT. No need to waive.
See https://nvbugspro.nvidia.com/bug/6191544 for details.

@galagam galagam closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants