Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 38844 - #14316

Merged
tburt-nv merged 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260519-155944
May 19, 2026
Merged

[None][infra] Waive 1 failed cases for main in pre-merge 38844#14316
tburt-nv merged 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260519-155944

Conversation

@ZhanruiSunCh

@ZhanruiSunCh ZhanruiSunCh commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @tburt-nv)
Target branch: main
Bug(s): 6192201

Waive entries added

perf/test_perf_sanity.py::test_e2e[aggr_upload-llama3_1_8b_fp8_ad_hopper-llama3_1_8b_ad_ws1_1k1k] SKIP (https://nvbugs/6192201)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Summary by CodeRabbit

  • Tests
    • Updated test infrastructure with a performance test waiver pending investigation.

Review Change Stack

Bug(s): 6192201
Requested by: @tburt-nv

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
@tburt-nv

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive only"

@tburt-nv
tburt-nv enabled auto-merge (squash) May 19, 2026 16:00
@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5a29fc05-d6ae-4b6b-bb54-ec84f20858bc

📥 Commits

Reviewing files that changed from the base of the PR and between a7f7229 and 911a8bf.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single waiver entry is appended to the test exemption list to skip a specific parameterized performance test case (perf/test_perf_sanity.py::test_e2e[aggr_upload-llama3_1_8b_fp8_ad_hopper-llama3_1_8b_ad_ws1_1k1k]) and associates it with nvbugs/6192201.

Changes

Test Waiver Update

Layer / File(s) Summary
Performance test waiver entry
tests/integration/test_lists/waives.txt
One SKIP waiver line is added for a specific parameterized test case with an nvbugs reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14163: Modifies the same waiver file by adding a separate SKIP entry for a different test case.
  • NVIDIA/TensorRT-LLM#14034: Adds a new SKIP waiver entry to the same file for a different parameterization of perf/test_perf_sanity.py::test_e2e[aggr_upload-...].
  • NVIDIA/TensorRT-LLM#14283: Updates the same waiver file by adding multiple SKIP entries for failing test cases, including another performance test parameterization.

Suggested reviewers

  • tburt-nv
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete according to the template. It lacks required sections for Description, Test Coverage, and PR Checklist with the verification checkbox. Add Description section explaining the waive entry, Test Coverage section documenting the waived test, and complete the PR Checklist with checkbox marked.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates this is an infrastructure change that waives 1 failed test case, matching the changeset which adds a single waiver entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49228 [ skip ] triggered by Bot. Commit: 911a8bf Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49228 [ skip ] completed with state SUCCESS. Commit: 911a8bf
Skipping testing for commit 911a8bf

Link to invocation

@tburt-nv
tburt-nv merged commit b2a5070 into NVIDIA:main May 19, 2026
12 checks passed
xxi-nv pushed a commit to xxi-nv/TensorRT-LLM that referenced this pull request May 22, 2026
…A#14316)

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
…A#14316)

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants