[https://nvbugs/5974335][refactor] Update model path definitions in test_perf.py and clean up waives.txt - #14393
Conversation
📝 WalkthroughWalkthroughThis PR updates performance test infrastructure by removing deprecated Llama v2 model entries, pruning Phi-4 multimodal variants, and adjusting model path mappings in ChangesPerf Test Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/defs/perf/test_perf.py (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUpdate the NVIDIA copyright year for this modified file.
Line 1 still ends at
2025, but this file is modified in 2026 and should be updated accordingly.Proposed fix
-# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.As per coding guidelines
**/*.{cpp,cc,h,hpp,py,cu,cuh}: "Include NVIDIA copyright header on ALL new files; update year on modified files."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/defs/perf/test_perf.py` at line 1, The SPDX copyright header in the modified file still lists the year 2025; update the SPDX-FileCopyrightText header string so the year is 2026 (i.e., change "2022-2025" to "2022-2026") in test_perf.py to reflect the 2026 modification.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@tests/integration/defs/perf/test_perf.py`:
- Line 1: The SPDX copyright header in the modified file still lists the year
2025; update the SPDX-FileCopyrightText header string so the year is 2026 (i.e.,
change "2022-2025" to "2022-2026") in test_perf.py to reflect the 2026
modification.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 54796924-3e0b-4aeb-aa76-69f39bf963b4
📒 Files selected for processing (2)
tests/integration/defs/perf/test_perf.pytests/integration/test_lists/waives.txt
|
/bot run |
|
PR_Github #50166 [ run ] triggered by Bot. Commit: |
|
Removed 7 dead /bot run |
|
Removed the 4 perf waivers that this PR originally added — author confirmed those nvbugs (5150255 / 5304388 / 6130334) no longer need to be waived. The PR is now purely the /bot run |
|
/bot run |
|
PR_Github #50185 [ run ] triggered by Bot. Commit: |
|
PR_Github #50166 [ run ] completed with state |
|
PR_Github #50185 [ run ] completed with state
|
…ean up waives.txt Removed outdated model paths and unnecessary entries from MODEL_PATH_DICT in test_perf.py. Updated waives.txt to reflect the removal of tests that are no longer applicable, improving clarity and maintainability. Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
These 7 waivers referenced perf tests (bart_large_cnn, bert_large, flan_t5_base/large/xl/xxl, mbart_large_50_many_to_one_mmt) that no longer appear in any test-db yaml on main. Drop them to keep the cleanup consistent with the 5 sibling waivers (roberta_base, t5_*) that were already removed in this PR. Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Drop the 4 perf waivers that the PR originally added — author confirmed the underlying nvbugs (5150255 / 5304388 / 6130334) are no longer necessary to waive. Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot skip --comment "only test list modify" |
|
PR_Github #50318 [ skip ] triggered by Bot. Commit: |
|
PR_Github #50318 [ skip ] completed with state |
…ean up waives.txt (NVIDIA#14393) Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Removed outdated model paths and unnecessary entries from MODEL_PATH_DICT in test_perf.py. Updated waives.txt to reflect the removal of tests that are no longer applicable, improving clarity and maintainability.
Signed-off-by: yufeiwu-nv 230315618+yufeiwu-nv@users.noreply.github.com
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.