Skip to content

[None][fix] unwaive TestNemotronNanoV3 tests - #14628

Closed
tcherckez-nvidia wants to merge 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:unwaive-6120981
Closed

[None][fix] unwaive TestNemotronNanoV3 tests#14628
tcherckez-nvidia wants to merge 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:unwaive-6120981

Conversation

@tcherckez-nvidia

@tcherckez-nvidia tcherckez-nvidia commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Removed a test skip waiver entry.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Tal Cherckez <127761168+tcherckez-nvidia@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR removes a single SKIP waiver entry from the integration test waiver list for the NemotronNanoV3 test_accuracy case with nvfp4-1-trtllm parameter, indicating the test is no longer waived.

Changes

Test waiver removal

Layer / File(s) Summary
NemotronNanoV3 test_accuracy waiver removal
tests/integration/test_lists/waives.txt
Removes the SKIP waiver entry for accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[nvfp4-1-trtllm] (previously waived via https://nvbugs/6200112), indicating the test is no longer waived.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • ZhanruiSunCh
  • mzweilz
  • jieli-matrix
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely populated with the template boilerplate and contains no substantive content—no actual description, test coverage details, or explanation of why the waiver was removed. Fill in the Description section explaining why TestNemotronNanoV3 test was unwaived and reference the related bug/issue. Provide specific test coverage information relevant to this change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly identifies the main change: removing a test waiver for TestNemotronNanoV3 tests, which matches the diff removing a SKIP waiver entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tcherckez-nvidia

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50530 [ run ] triggered by Bot. Commit: 17c4964 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50530 [ run ] completed with state SUCCESS. Commit: 17c4964
/LLM/main/L0_MergeRequest_PR pipeline #40037 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@galagam

galagam commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Test already unwaived

@galagam galagam closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants